From: Devin Heitmueller Date: Tue, 24 Apr 2018 23:12:52 +0000 (-0400) Subject: media: cx88: Get rid of spurious call to cx8800_start_vbi_dma() X-Git-Tag: v5.15~8685^2~208 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=b3a78df581641fdbeb19c6ed162112fcf2ae48f7;p=platform%2Fkernel%2Flinux-starfive.git media: cx88: Get rid of spurious call to cx8800_start_vbi_dma() This was left over from the conversion to VB2, where the call was getting invoked both in buffer_queue and start_streaming, which was intermittently causing invalid opcodes on the VBI RISC queue. This change effectively mirrors the exact same change Hans Verkuil made in cx88-video.c in commit 389208e1173e ("[media] cx88: remove leftover start_video_dma() call"). Thanks to Daniel Glöckner for spotting the actual bug after I spent several days trying to chase down the issue. Fixes: 389208e1173e ("[media] cx88: remove leftover start_video_dma() call") Signed-off-by: Devin Heitmueller Thanks-to: Daniel Glöckner Cc: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab --- diff --git a/drivers/media/pci/cx88/cx88-vbi.c b/drivers/media/pci/cx88/cx88-vbi.c index c637679..58489ea 100644 --- a/drivers/media/pci/cx88/cx88-vbi.c +++ b/drivers/media/pci/cx88/cx88-vbi.c @@ -178,7 +178,6 @@ static void buffer_queue(struct vb2_buffer *vb) if (list_empty(&q->active)) { list_add_tail(&buf->list, &q->active); - cx8800_start_vbi_dma(dev, q, buf); dprintk(2, "[%p/%d] vbi_queue - first active\n", buf, buf->vb.vb2_buf.index);