From: Jihoon Kim <jihoon48.kim@samsung.com>
Date: Tue, 18 Jul 2017 10:25:07 +0000 (+0900)
Subject: Fix logical error unsigned variable compares with negative value
X-Git-Tag: submit/tizen_3.0/20170718.224708~1
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=b374823829e3fe6246bdcbde06dce35d3fa51b2b;p=platform%2Fcore%2Fuifw%2Flibscl-core.git

Fix logical error unsigned variable compares with negative value

Expression 'type < 0' is always false , which may be caused by a logical error

Change-Id: Ia5c0c56972e43e96636efb3de60b2a2fd2d16d51
Signed-off-by: Jihoon Kim <jihoon48.kim@samsung.com>
(cherry picked from commit 5381c90889fa2af853054b815cd3cec6562905e3)
---

diff --git a/src/sclcoreui-efl.cpp b/src/sclcoreui-efl.cpp
index 6caa4da..bea0d01 100644
--- a/src/sclcoreui-efl.cpp
+++ b/src/sclcoreui-efl.cpp
@@ -652,7 +652,7 @@ set_transient_for_isf_setting_window(Evas_Object *window)
 
 sclwindow CSCLCoreUIEFL::create_option_window(SCLOptionWindowType type)
 {
-    if (type < 0 || type >= OPTION_WINDOW_TYPE_MAX) {
+    if (type >= OPTION_WINDOW_TYPE_MAX) {
         return SCLWINDOW_INVALID;
     }
 
@@ -730,7 +730,7 @@ sclwindow CSCLCoreUIEFL::create_option_window(SCLOptionWindowType type)
 
 bool CSCLCoreUIEFL::show_option_window(SCLOptionWindowType type)
 {
-    if (type < 0 || type >= OPTION_WINDOW_TYPE_MAX) {
+    if (type >= OPTION_WINDOW_TYPE_MAX) {
         return SCLWINDOW_INVALID;
     }