From: Jakub Kicinski Date: Fri, 6 May 2022 20:00:29 +0000 (-0700) Subject: eth: dpaa2-mac: remove a dead-code NULL check on fwnode parent X-Git-Tag: v6.1-rc5~1274^2~156 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=b3552d6a3b8bd4260a971f1f70140ed3513cc4f7;p=platform%2Fkernel%2Flinux-starfive.git eth: dpaa2-mac: remove a dead-code NULL check on fwnode parent Since commit 4e30e98c4b4c ("dpaa2-mac: return -EPROBE_DEFER from dpaa2_mac_open in case the fwnode is not set") @parent can't be NULL after the if. It's either the address of the ->fwnode of @dpmacs or @fwnode in case of ACPI. Signed-off-by: Jakub Kicinski Link: https://lore.kernel.org/r/20220506200029.852310-1-kuba@kernel.org Signed-off-by: Paolo Abeni --- diff --git a/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c b/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c index c48811d..c9bee9a 100644 --- a/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c +++ b/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c @@ -108,9 +108,6 @@ static struct fwnode_handle *dpaa2_mac_get_node(struct device *dev, return ERR_PTR(-EPROBE_DEFER); } - if (!parent) - return NULL; - fwnode_for_each_child_node(parent, child) { err = -EINVAL; if (is_acpi_device_node(child))