From: Jiasheng Jiang Date: Thu, 24 Feb 2022 06:28:49 +0000 (+0800) Subject: iio: adc: Add check for devm_request_threaded_irq X-Git-Tag: v6.6.17~7878^2~55^2~33 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=b30537a4cedcacf0ade2f33ebb7610178ed1e7d7;p=platform%2Fkernel%2Flinux-rpi.git iio: adc: Add check for devm_request_threaded_irq As the potential failure of the devm_request_threaded_irq(), it should be better to check the return value and return error if fails. Fixes: fa659a40b80b ("iio: adc: twl6030-gpadc: Use devm_* API family") Signed-off-by: Jiasheng Jiang Link: https://lore.kernel.org/r/20220224062849.3280966-1-jiasheng@iscas.ac.cn Signed-off-by: Jonathan Cameron --- diff --git a/drivers/iio/adc/twl6030-gpadc.c b/drivers/iio/adc/twl6030-gpadc.c index 4966997..f53e855 100644 --- a/drivers/iio/adc/twl6030-gpadc.c +++ b/drivers/iio/adc/twl6030-gpadc.c @@ -911,6 +911,8 @@ static int twl6030_gpadc_probe(struct platform_device *pdev) ret = devm_request_threaded_irq(dev, irq, NULL, twl6030_gpadc_irq_handler, IRQF_ONESHOT, "twl6030_gpadc", indio_dev); + if (ret) + return ret; ret = twl6030_gpadc_enable_irq(TWL6030_GPADC_RT_SW1_EOC_MASK); if (ret < 0) {