From: Zhaomo Yang <zhaomo@google.com>
Date: Thu, 3 Jun 2021 00:15:41 +0000 (+0000)
Subject: Fix "control reaches end of non-void function" warnings on ppc64le
X-Git-Tag: llvmorg-14-init~5000
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=b2c8bcbab8a44c4582632845697b9425c3200230;p=platform%2Fupstream%2Fllvm.git

Fix "control reaches end of non-void function" warnings on ppc64le

Warnings can be found here: https://lab.llvm.org/buildbot/#/builders/76/builds/2640

Reviewed By: ymandel

Differential Revision: https://reviews.llvm.org/D103565
---

diff --git a/clang/lib/ASTMatchers/GtestMatchers.cpp b/clang/lib/ASTMatchers/GtestMatchers.cpp
index 79f69c6..6e4c12f 100644
--- a/clang/lib/ASTMatchers/GtestMatchers.cpp
+++ b/clang/lib/ASTMatchers/GtestMatchers.cpp
@@ -53,6 +53,7 @@ static DeclarationMatcher getComparisonDecl(GtestCmp Cmp) {
   case GtestCmp::Lt:
     return functionDecl(hasName("::testing::internal::CmpHelperLT"));
   }
+  llvm_unreachable("Unhandled GtestCmp enum");
 }
 
 static llvm::StringRef getMacroTypeName(MacroType Macro) {
@@ -64,6 +65,7 @@ static llvm::StringRef getMacroTypeName(MacroType Macro) {
   case MacroType::On:
     return "ON";
   }
+  llvm_unreachable("Unhandled MacroType enum");
 }
 
 static llvm::StringRef getComparisonTypeName(GtestCmp Cmp) {
@@ -81,6 +83,7 @@ static llvm::StringRef getComparisonTypeName(GtestCmp Cmp) {
   case GtestCmp::Lt:
     return "LT";
   }
+  llvm_unreachable("Unhandled GtestCmp enum");
 }
 
 static std::string getMacroName(MacroType Macro, GtestCmp Cmp) {
@@ -104,6 +107,7 @@ static llvm::StringRef getSpecSetterName(MacroType Macro) {
   default:
     llvm_unreachable("Unhandled MacroType enum");
   }
+  llvm_unreachable("Unhandled MacroType enum");
 }
 
 // In general, AST matchers cannot match calls to macros. However, we can
@@ -170,6 +174,7 @@ gtestCallInternal(MacroType Macro, StatementMatcher MockCall, MockArgs Args) {
             hasOverloadedOperatorName("()"), argumentCountIs(3),
             hasArgument(0, ignoringImplicit(MockCall))))));
   }
+  llvm_unreachable("Unhandled MockArgs enum");
 }
 
 static internal::BindableMatcher<Stmt>