From: Antony Pavlov Date: Sat, 31 Aug 2013 17:22:39 +0000 (+0400) Subject: milkymist-uart: use qemu_chr_fe_write_all() instead of qemu_chr_fe_write() X-Git-Tag: Tizen_Studio_1.3_Release_p2.3.1~386^2~42^2~201^2~9 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=b2c623a3d9c88fb1d3bbbbe97364dc65bc6ab363;p=sdk%2Femulator%2Fqemu.git milkymist-uart: use qemu_chr_fe_write_all() instead of qemu_chr_fe_write() qemu_chr_fe_write() is capable of returning 0 to indicate EAGAIN (and friends) and we don't handle this. Just change it to qemu_chr_fe_write_all() to fix. Reported-by: Peter Crosthwaite Acked-by: Peter Crosthwaite Signed-off-by: Antony Pavlov Signed-off-by: Michael Walle Reviewed-by: Peter Maydell --- diff --git a/hw/char/milkymist-uart.c b/hw/char/milkymist-uart.c index 2c52a0fa8e..da51f82eac 100644 --- a/hw/char/milkymist-uart.c +++ b/hw/char/milkymist-uart.c @@ -124,7 +124,7 @@ static void uart_write(void *opaque, hwaddr addr, uint64_t value, switch (addr) { case R_RXTX: if (s->chr) { - qemu_chr_fe_write(s->chr, &ch, 1); + qemu_chr_fe_write_all(s->chr, &ch, 1); } s->regs[R_STAT] |= STAT_TX_EVT; break;