From: Marcel Holtmann <marcel@holtmann.org>
Date: Tue, 7 Jul 2015 09:28:34 +0000 (+0200)
Subject: gatchat: Fix compiler warning with logical expression
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=b2b67fa74ebf24a20d1b44fa2036b106b4a0d722;p=platform%2Fupstream%2Fofono.git

gatchat: Fix compiler warning with logical expression

  CC       gatchat/gatchat.o
gatchat/gatchat.c: In function ‘have_line’:
gatchat/gatchat.c:586:28: error: logical not is only applied to the left hand side of comparison [-Werror=logical-not-parentheses]
  if (!strncmp(str, "AT", 2) == TRUE)
                            ^
---

diff --git a/gatchat/gatchat.c b/gatchat/gatchat.c
index 33bfc212..d7d00605 100644
--- a/gatchat/gatchat.c
+++ b/gatchat/gatchat.c
@@ -583,7 +583,7 @@ static void have_line(struct at_chat *p, char *str)
 		return;
 
 	/* Check for echo, this should not happen, but lets be paranoid */
-	if (!strncmp(str, "AT", 2) == TRUE)
+	if (!strncmp(str, "AT", 2))
 		goto done;
 
 	cmd = g_queue_peek_head(p->command_queue);