From: Stephen Toub <stoub@microsoft.com>
Date: Tue, 16 Jul 2019 00:14:02 +0000 (-0400)
Subject: Remove unnecessary "internal" from JsonConverterFactory ctor (dotnet/corefx#39504)
X-Git-Tag: submit/tizen/20210909.063632~11031^2~928
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=b2ae1c1a85f3df9dcca2b18398483a6bb0f22fdc;p=platform%2Fupstream%2Fdotnet%2Fruntime.git

Remove unnecessary "internal" from JsonConverterFactory ctor (dotnet/corefx#39504)

The ctor is already `protected`, so it can already be accessed by any derived type.  The only benefit adding `internal` would provide is so that it could be called directly by something else in the assembly, but the type is `abstract`, so that doesn't make sense for a ctor.

Commit migrated from https://github.com/dotnet/corefx/commit/902294e7933e84601aa4543fc3afe0dcf85c2d99
---

diff --git a/src/libraries/System.Text.Json/ref/System.Text.Json.cs b/src/libraries/System.Text.Json/ref/System.Text.Json.cs
index 82bc52d..b4120e2 100644
--- a/src/libraries/System.Text.Json/ref/System.Text.Json.cs
+++ b/src/libraries/System.Text.Json/ref/System.Text.Json.cs
@@ -466,7 +466,7 @@ namespace System.Text.Json.Serialization
     }
     public abstract partial class JsonConverterFactory : System.Text.Json.Serialization.JsonConverter
     {
-        protected internal JsonConverterFactory() { }
+        protected JsonConverterFactory() { }
         public abstract System.Text.Json.Serialization.JsonConverter CreateConverter(System.Type typeToConvert, System.Text.Json.JsonSerializerOptions options);
     }
     public abstract partial class JsonConverter<T> : System.Text.Json.Serialization.JsonConverter
diff --git a/src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonConverterFactory.cs b/src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonConverterFactory.cs
index 5e4d686..35cdd39 100644
--- a/src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonConverterFactory.cs
+++ b/src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonConverterFactory.cs
@@ -17,7 +17,7 @@ namespace System.Text.Json.Serialization
         /// <summary>
         /// When overidden, constructs a new <see cref="JsonConverterFactory"/> instance.
         /// </summary>
-        protected internal JsonConverterFactory() { }
+        protected JsonConverterFactory() { }
 
         internal JsonConverter GetConverterInternal(Type typeToConvert, JsonSerializerOptions options)
         {