From: Pavel Machek <pavel@ucw.cz>
Date: Sun, 20 Sep 2020 09:01:37 +0000 (+0200)
Subject: media: firewire: fix memory leak
X-Git-Tag: v5.10.7~1469^2~104
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=b28e32798c78a346788d412f1958f36bb760ec03;p=platform%2Fkernel%2Flinux-rpi.git

media: firewire: fix memory leak

Fix memory leak in node_probe.

Signed-off-by: Pavel Machek (CIP) <pavel@denx.de>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
---

diff --git a/drivers/media/firewire/firedtv-fw.c b/drivers/media/firewire/firedtv-fw.c
index 3f1ca40..8a85852 100644
--- a/drivers/media/firewire/firedtv-fw.c
+++ b/drivers/media/firewire/firedtv-fw.c
@@ -272,8 +272,10 @@ static int node_probe(struct fw_unit *unit, const struct ieee1394_device_id *id)
 
 	name_len = fw_csr_string(unit->directory, CSR_MODEL,
 				 name, sizeof(name));
-	if (name_len < 0)
-		return name_len;
+	if (name_len < 0) {
+		err = name_len;
+		goto fail_free;
+	}
 	for (i = ARRAY_SIZE(model_names); --i; )
 		if (strlen(model_names[i]) <= name_len &&
 		    strncmp(name, model_names[i], name_len) == 0)