From: Minje Ahn <minje.ahn@samsung.com>
Date: Thu, 29 Sep 2016 01:22:12 +0000 (+0900)
Subject: Code refactoring
X-Git-Tag: submit/tizen/20161005.055916^0
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=b273c25f11508ddfc4498ff1062a6d3f4b2a67e0;p=platform%2Fcore%2Fapi%2Fthumbnail-util.git

Code refactoring

Change-Id: I4024bac860c3c3473e7b4e4f4f5ec4accd32cd7c
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
---

diff --git a/packaging/capi-media-thumbnail-util.spec b/packaging/capi-media-thumbnail-util.spec
index 3430cf3..097070e 100755
--- a/packaging/capi-media-thumbnail-util.spec
+++ b/packaging/capi-media-thumbnail-util.spec
@@ -1,6 +1,6 @@
 Name:       capi-media-thumbnail-util
 Summary:    A media thumbnail util library in Tizen Native API
-Version: 0.1.3
+Version: 0.1.4
 Release:    1
 Group:      Multimedia/API
 License:    Apache-2.0
diff --git a/src/thumbnail_util.c b/src/thumbnail_util.c
index 95ef49f..8707fbc 100755
--- a/src/thumbnail_util.c
+++ b/src/thumbnail_util.c
@@ -50,15 +50,10 @@ int __thumbnail_util_error_capi(int content_error)
 
 void __thumbnail_util_convert_itoa(int request_id, char **req_str)
 {
-	char *buf = NULL;
+	char buf[MAX_SIZE] = {0, };
 
-	buf = malloc(MAX_SIZE * sizeof(char));
-
-	if (buf != NULL) {
-		snprintf(buf, MAX_SIZE, "%d", request_id);
-		*req_str = strndup(buf, strlen(buf));
-		SAFE_FREE(buf);
-	}
+	snprintf(buf, MAX_SIZE, "%d", request_id);
+	*req_str = strndup(buf, strlen(buf));
 }
 void __thumbnail_util_extract_completed_cb(int error, int request_id, const char *path, int thumb_width, int thumb_height, unsigned char *thumb_data, int thumb_size, void *user_data)
 {
@@ -141,8 +136,7 @@ int thumbnail_util_set_path(thumbnail_h thumb, const char *path)
 	thumbnail_s *_thumb = (thumbnail_s *)thumb;
 
 	if (_thumb != NULL && path != NULL) {
-		if (_thumb->file_path)
-			SAFE_FREE(_thumb->file_path);
+		SAFE_FREE(_thumb->file_path);
 		_thumb->file_path = strndup(path, strlen(path));
 	} else {
 		thumbnail_util_error("INVALID_PARAMETER(0x%08x)", THUMBNAIL_UTIL_ERROR_INVALID_PARAMETER);
diff --git a/test/thumbnail_util_test.c b/test/thumbnail_util_test.c
index 1309547..05334bd 100755
--- a/test/thumbnail_util_test.c
+++ b/test/thumbnail_util_test.c
@@ -84,8 +84,8 @@ gboolean extract_thumbnail_start(gpointer data)
 #else
 	thumbnail_h test_info;
 	thumbnail_util_create(&test_info);
-	thumbnail_util_set_path(test_info, "/home/owner/content/Images/test_image1.jpg");
-	/*thumbnail_util_set_size(test_info, 511, 288); */
+	thumbnail_util_set_path(test_info, "/opt/usr/home/owner/media/Images/test_image1.jpg");
+	thumbnail_util_set_size(test_info, 511, 288);
 	ret = thumbnail_util_extract(test_info, thumbnail_completed_cb, test_info, &g_id);
 #endif
 	thumbnail_util_destroy(test_info);