From: Konstantin Baladurin Date: Wed, 4 Apr 2018 16:38:22 +0000 (+0300) Subject: [x86/Linux] Fix COMNumber::DoubleToNumberFC arguments order (dotnet/coreclr#17412) X-Git-Tag: submit/tizen/20210909.063632~11030^2~5093 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=b24040f4aaf76ec2702e6a458722570ddf163074;p=platform%2Fupstream%2Fdotnet%2Fruntime.git [x86/Linux] Fix COMNumber::DoubleToNumberFC arguments order (dotnet/coreclr#17412) We should use FCDECL3_VII/FCIMPL3_VII instead of FCDECL3/FCIMPL3 otherwise we got incorrect order of arguments that leads to crashes. Commit migrated from https://github.com/dotnet/coreclr/commit/fe44fe6526ea3c6e6322f3684651c14865431dcf --- diff --git a/src/coreclr/src/classlibnative/bcltype/number.cpp b/src/coreclr/src/classlibnative/bcltype/number.cpp index 69ee0d6..ac068d6 100644 --- a/src/coreclr/src/classlibnative/bcltype/number.cpp +++ b/src/coreclr/src/classlibnative/bcltype/number.cpp @@ -1983,7 +1983,7 @@ ParseSection: #pragma warning(pop) #endif -FCIMPL3(void, COMNumber::DoubleToNumberFC, double value, int precision, NUMBER* number) +FCIMPL3_VII(void, COMNumber::DoubleToNumberFC, double value, int precision, NUMBER* number) { FCALL_CONTRACT; diff --git a/src/coreclr/src/classlibnative/bcltype/number.h b/src/coreclr/src/classlibnative/bcltype/number.h index c225b3e..bf1f328 100644 --- a/src/coreclr/src/classlibnative/bcltype/number.h +++ b/src/coreclr/src/classlibnative/bcltype/number.h @@ -31,7 +31,7 @@ struct NUMBER { class COMNumber { public: - static FCDECL3(void, DoubleToNumberFC, double value, int precision, NUMBER* number); + static FCDECL3_VII(void, DoubleToNumberFC, double value, int precision, NUMBER* number); static FCDECL1(double, NumberToDoubleFC, NUMBER* number); static FCDECL2(FC_BOOL_RET, NumberBufferToDecimal, NUMBER* number, DECIMAL* value);