From: changhuang.liang <changhuang.liang@starfivetech.com>
Date: Fri, 20 May 2022 07:52:30 +0000 (+0800)
Subject: pmic: modify pmic function
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=b22c843ee441208c3d26df0835a5faccc3306f07;p=platform%2Fkernel%2Flinux-starfive.git

pmic: modify pmic function

Signed-off-by: changhuang.liang <changhuang.liang@starfivetech.com>
---

diff --git a/drivers/soc/starfive/jh7110_pmic.c b/drivers/soc/starfive/jh7110_pmic.c
index 7d5f8a6f..40d6348 100644
--- a/drivers/soc/starfive/jh7110_pmic.c
+++ b/drivers/soc/starfive/jh7110_pmic.c
@@ -11,6 +11,8 @@
 #include <linux/device.h>
 #include <soc/starfive/jh7110_pmic.h>
 
+static struct pmic_dev *pmic_dev;
+
 static int pmic_read_reg(struct pmic_dev *pmic_dev, u8 reg)
 {
 	struct i2c_client *client = pmic_dev->i2c_client;
@@ -43,8 +45,7 @@ static void pmic_set_bit(struct pmic_dev *pmic_dev, u8 reg, u8 mask, u8 val)
 	pmic_write_reg(pmic_dev, reg, val);
 }
 
-void pmic_set_domain(struct pmic_dev *pmic_dev, u8 reg,
-		u8 domain, u8 on)
+void pmic_set_domain(u8 reg, u8 domain, u8 on)
 {
 	pmic_set_bit(pmic_dev, reg, BIT(domain), on<<domain);
 }
@@ -53,7 +54,6 @@ EXPORT_SYMBOL(pmic_set_domain);
 static int pmic_probe(struct i2c_client *client)
 {
 	struct device *dev = &client->dev;
-	struct pmic_dev *pmic_dev;
 	u8 val = 0;
 
 	pmic_dev = devm_kzalloc(dev, sizeof(*pmic_dev), GFP_KERNEL);
diff --git a/include/soc/starfive/jh7110_pmic.h b/include/soc/starfive/jh7110_pmic.h
index 7fcd15c..304927e 100644
--- a/include/soc/starfive/jh7110_pmic.h
+++ b/include/soc/starfive/jh7110_pmic.h
@@ -32,12 +32,10 @@ struct pmic_dev {
 };
 
 /**
- * @pmic_dev: pmic device.
  * @reg: see enum pmic_reg.
  * @domian: see enum pmic_power_domian.
  * @on: power swtich, 1 or 0.
  */
-void pmic_set_domain(struct pmic_dev *pmic_dev, u8 reg,
-		u8 domain, u8 on);
+void pmic_set_domain(u8 reg, u8 domain, u8 on);
 
 #endif