From: Lee Jones Date: Fri, 23 Nov 2012 15:19:29 +0000 (+0000) Subject: mfd: Simplify IRQ domain registration code in STMPE X-Git-Tag: v3.8-rc1~85^2~21 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=b20a43715e675815d0a426f05a7607ba099136aa;p=profile%2Fivi%2Fkernel-x86-ivi.git mfd: Simplify IRQ domain registration code in STMPE Historically, a driver would have to decide whether it required a Linear or Legacy IRQ domain when registering one. This can end up as quite a lot of code. A new Simple call now exists which simplifies this process. Let's make use of it here. Reviewed-by: Viresh Kumar Signed-off-by: Lee Jones Signed-off-by: Samuel Ortiz --- diff --git a/drivers/mfd/stmpe.c b/drivers/mfd/stmpe.c index c0df4b9..0061d1b 100644 --- a/drivers/mfd/stmpe.c +++ b/drivers/mfd/stmpe.c @@ -888,18 +888,14 @@ static struct irq_domain_ops stmpe_irq_ops = { static int __devinit stmpe_irq_init(struct stmpe *stmpe, struct device_node *np) { - int base = stmpe->irq_base; + int base = 0; int num_irqs = stmpe->variant->num_irqs; - if (base) { - stmpe->domain = irq_domain_add_legacy( - np, num_irqs, base, 0, &stmpe_irq_ops, stmpe); - } - else { - stmpe->domain = irq_domain_add_linear( - np, num_irqs, &stmpe_irq_ops, stmpe); - } + if (!np) + base = stmpe->irq_base; + stmpe->domain = irq_domain_add_simple(np, num_irqs, base, + &stmpe_irq_ops, stmpe); if (!stmpe->domain) { dev_err(stmpe->dev, "Failed to create irqdomain\n"); return -ENOSYS;