From: Frederic Danis Date: Fri, 15 May 2015 09:58:41 +0000 (+0200) Subject: Bluetooth: btintel: Fix calls to __hci_cmd_sync() X-Git-Tag: v4.9.8~4072^2~183^2~63 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=b1f5cf0cae090dae9ac045670fec2d0c5253592a;p=platform%2Fkernel%2Flinux-rpi3.git Bluetooth: btintel: Fix calls to __hci_cmd_sync() Remove test of command reply status as it is already performed by __hci_cmd_sync(). __hci_cmd_sync_ev() function already returns an error if it got a non-zero status either through a Command Complete or a Command Status event. For both of these events the status is collected up in the event handlers called by hci_event_packet() and then passed as the second parameter to req_complete_skb(). The req_complete_skb() callback in turn is hci_req_sync_complete() for __hci_cmd_sync_ev() which stores the status in hdev->req_result. The hdev->req_result is then further converted through bt_to_errno() back in __hci_cmd_sync_ev(). Signed-off-by: Frederic Danis Signed-off-by: Marcel Holtmann --- diff --git a/drivers/bluetooth/btintel.c b/drivers/bluetooth/btintel.c index 2d43d42..828f2f8 100644 --- a/drivers/bluetooth/btintel.c +++ b/drivers/bluetooth/btintel.c @@ -53,12 +53,6 @@ int btintel_check_bdaddr(struct hci_dev *hdev) } bda = (struct hci_rp_read_bd_addr *)skb->data; - if (bda->status) { - BT_ERR("%s: Intel device address result failed (%02x)", - hdev->name, bda->status); - kfree_skb(skb); - return -bt_to_errno(bda->status); - } /* For some Intel based controllers, the default Bluetooth device * address 00:03:19:9E:8B:00 can be found. These controllers are