From: Miaoqian Lin Date: Wed, 1 Jun 2022 08:09:26 +0000 (+0400) Subject: irqchip/apple-aic: Fix refcount leak in build_fiq_affinity X-Git-Tag: v6.1-rc5~929^2^2~10 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=b1ac803f47cb1615468f35cf1ccb553c52087301;p=platform%2Fkernel%2Flinux-starfive.git irqchip/apple-aic: Fix refcount leak in build_fiq_affinity of_find_node_by_phandle() returns a node pointer with refcount incremented, we should use of_node_put() on it when not need anymore. Add missing of_node_put() to avoid refcount leak. Fixes: a5e8801202b3 ("irqchip/apple-aic: Parse FIQ affinities from device-tree") Signed-off-by: Miaoqian Lin Signed-off-by: Marc Zyngier Link: https://lore.kernel.org/r/20220601080930.31005-3-linmq006@gmail.com --- diff --git a/drivers/irqchip/irq-apple-aic.c b/drivers/irqchip/irq-apple-aic.c index 12dd487..478d0af 100644 --- a/drivers/irqchip/irq-apple-aic.c +++ b/drivers/irqchip/irq-apple-aic.c @@ -1035,6 +1035,7 @@ static void build_fiq_affinity(struct aic_irq_chip *ic, struct device_node *aff) continue; cpu = of_cpu_node_to_id(cpu_node); + of_node_put(cpu_node); if (WARN_ON(cpu < 0)) continue;