From: Fengguang Wu Date: Mon, 27 Nov 2017 09:25:29 +0000 (-0500) Subject: media: dvb_frontend: fix ifnullfree.cocci warnings X-Git-Tag: v4.19~1636^2~275 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=b1728ff617f88a1f7a5d8c8f21fe17a2f6af5d16;p=platform%2Fkernel%2Flinux-rpi.git media: dvb_frontend: fix ifnullfree.cocci warnings drivers/media/dvb-core/dvb_frontend.c:154:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values. NULL check before some freeing functions is not needed. Based on checkpatch warning "kfree(NULL) is safe this check is probably not required" and kfreeaddr.cocci by Julia Lawall. Generated by: scripts/coccinelle/free/ifnullfree.cocci Fixes: b1cb7372fa82 ("dvb_frontend: don't use-after-free the frontend struct") Signed-off-by: Fengguang Wu Signed-off-by: Mauro Carvalho Chehab --- diff --git a/drivers/media/dvb-core/dvb_frontend.c b/drivers/media/dvb-core/dvb_frontend.c index 4eedaa5..e8c7ded 100644 --- a/drivers/media/dvb-core/dvb_frontend.c +++ b/drivers/media/dvb-core/dvb_frontend.c @@ -150,8 +150,7 @@ static void __dvb_frontend_free(struct dvb_frontend *fe) dvb_frontend_invoke_release(fe, fe->ops.release); - if (fepriv) - kfree(fepriv); + kfree(fepriv); } static void dvb_frontend_free(struct kref *ref)