From: Takashi Iwai Date: Wed, 4 Jul 2018 14:01:46 +0000 (+0200) Subject: ASoC: stm32: Use snd_pcm_stop_xrun() helper X-Git-Tag: v5.15~7441^2~18^2~412 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=b1625fbb3b87affbedf14545b65d69ff182a0611;p=platform%2Fkernel%2Flinux-starfive.git ASoC: stm32: Use snd_pcm_stop_xrun() helper The XRUN trigger from the driver should be done via snd_pcm_stop_xrun(). It simplifies the locking as well. Signed-off-by: Takashi Iwai Signed-off-by: Mark Brown --- diff --git a/sound/soc/stm/stm32_sai_sub.c b/sound/soc/stm/stm32_sai_sub.c index c4f15ea..06fba96 100644 --- a/sound/soc/stm/stm32_sai_sub.c +++ b/sound/soc/stm/stm32_sai_sub.c @@ -300,11 +300,8 @@ static irqreturn_t stm32_sai_isr(int irq, void *devid) status = SNDRV_PCM_STATE_XRUN; } - if (status != SNDRV_PCM_STATE_RUNNING) { - snd_pcm_stream_lock(sai->substream); - snd_pcm_stop(sai->substream, SNDRV_PCM_STATE_XRUN); - snd_pcm_stream_unlock(sai->substream); - } + if (status != SNDRV_PCM_STATE_RUNNING) + snd_pcm_stop_xrun(sai->substream); return IRQ_HANDLED; }