From: Matthew Waters <matthew@centricular.com>
Date: Fri, 29 Oct 2021 07:38:37 +0000 (+1100)
Subject: webrtc/tests: give slightly better names to the dot file dumps
X-Git-Tag: 1.22.0~1986
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=b153ffdd56359584dbaf8810c6fbb900ddf40fc6;p=platform%2Fupstream%2Fgstreamer.git

webrtc/tests: give slightly better names to the dot file dumps

Don't use printf-specifiers with g_strconcat().

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1664>
---

diff --git a/subprojects/gst-plugins-bad/tests/check/elements/webrtcbin.c b/subprojects/gst-plugins-bad/tests/check/elements/webrtcbin.c
index 6819fedc..a07f1fb 100644
--- a/subprojects/gst-plugins-bad/tests/check/elements/webrtcbin.c
+++ b/subprojects/gst-plugins-bad/tests/check/elements/webrtcbin.c
@@ -318,8 +318,9 @@ _bus_watch (GstBus * bus, GstMessage * msg, struct test_webrtc *t)
         gst_message_parse_state_changed (msg, &old, &new, &pending);
 
         {
-          gchar *dump_name = g_strconcat ("%s-state_changed-",
-              GST_OBJECT_NAME (msg->src), gst_element_state_get_name (old), "_",
+          gchar *dump_name =
+              g_strconcat (GST_OBJECT_NAME (msg->src), "-state_changed-",
+              gst_element_state_get_name (old), "_",
               gst_element_state_get_name (new), NULL);
           GST_DEBUG_BIN_TO_DOT_FILE_WITH_TS (GST_BIN (msg->src),
               GST_DEBUG_GRAPH_SHOW_ALL, dump_name);
@@ -333,13 +334,11 @@ _bus_watch (GstBus * bus, GstMessage * msg, struct test_webrtc *t)
 
       {
         gchar *dump_name;
-        dump_name =
-            g_strconcat ("%s-error", GST_OBJECT_NAME (t->webrtc1), NULL);
+        dump_name = g_strconcat (GST_OBJECT_NAME (t->webrtc1), "-error", NULL);
         GST_DEBUG_BIN_TO_DOT_FILE_WITH_TS (GST_BIN (t->webrtc1),
             GST_DEBUG_GRAPH_SHOW_ALL, dump_name);
         g_free (dump_name);
-        dump_name =
-            g_strconcat ("%s-error", GST_OBJECT_NAME (t->webrtc2), NULL);
+        dump_name = g_strconcat (GST_OBJECT_NAME (t->webrtc2), "-error", NULL);
         GST_DEBUG_BIN_TO_DOT_FILE_WITH_TS (GST_BIN (t->webrtc2),
             GST_DEBUG_GRAPH_SHOW_ALL, dump_name);
         g_free (dump_name);