From: Jonathan Bakker Date: Thu, 30 Jul 2020 23:01:07 +0000 (+0200) Subject: media: exynos4-is: Correct missing entity function initialization X-Git-Tag: v5.10.7~1469^2~416 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=b127f8db753aadab3fb5883713ffb2ee2e8bf16c;p=platform%2Fkernel%2Flinux-rpi.git media: exynos4-is: Correct missing entity function initialization Commit bae4500399c4 ("[media] exynos4-is: Add missing entity function initialization") tried to suppress the warnings such as s5p-fimc-md camera: Entity type for entity FIMC.0 was not initialized! However, this missed setting for the subdev. Set it now to avoid the ugly warnings on boot. Signed-off-by: Jonathan Bakker Reviewed-by: Sylwester Nawrocki Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab --- diff --git a/drivers/media/platform/exynos4-is/fimc-capture.c b/drivers/media/platform/exynos4-is/fimc-capture.c index 4fbf550..73b632e 100644 --- a/drivers/media/platform/exynos4-is/fimc-capture.c +++ b/drivers/media/platform/exynos4-is/fimc-capture.c @@ -1888,6 +1888,7 @@ int fimc_initialize_capture_subdev(struct fimc_dev *fimc) return ret; sd->entity.ops = &fimc_sd_media_ops; + sd->entity.function = MEDIA_ENT_F_PROC_VIDEO_SCALER; sd->internal_ops = &fimc_capture_sd_internal_ops; v4l2_set_subdevdata(sd, fimc); return 0;