From: Alessandro Decina <alessandro.d@gmail.com>
Date: Wed, 22 Dec 2010 12:56:12 +0000 (+0100)
Subject: encodebin: minor fix in error handling.
X-Git-Tag: 1.19.3~511^2~6555^2~1289
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=b11303319cd7fe184eaadaf65016f343accb0729;p=platform%2Fupstream%2Fgstreamer.git

encodebin: minor fix in error handling.

Don't call gst_bin_remove (bin, <invalid pointer>).
---

diff --git a/gst/encoding/gstencodebin.c b/gst/encoding/gstencodebin.c
index 002ab16..b6e2dc4 100644
--- a/gst/encoding/gstencodebin.c
+++ b/gst/encoding/gstencodebin.c
@@ -1320,7 +1320,7 @@ static gboolean
 create_elements_and_pads (GstEncodeBin * ebin)
 {
   gboolean ret = TRUE;
-  GstElement *muxer;
+  GstElement *muxer = NULL;
   GstPad *muxerpad;
   const GList *tmp, *profiles;
   GstEncodingProfile *sprof;
@@ -1400,7 +1400,8 @@ no_muxer_ghost_pad:
 stream_error:
   {
     GST_WARNING ("Could not create Streams");
-    gst_bin_remove (GST_BIN (ebin), muxer);
+    if (muxer)
+      gst_bin_remove (GST_BIN (ebin), muxer);
     ebin->muxer = NULL;
     return FALSE;
   }