From: Uwe Kleine-König Date: Fri, 27 Mar 2009 23:26:38 +0000 (+0100) Subject: leds: move h1940-leds's probe function to .devinit.text X-Git-Tag: v2.6.30-rc1~187^2~3 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=b0edba7ef89a64614e40023bf87ed5b402834e04;p=platform%2Fkernel%2Flinux-3.10.git leds: move h1940-leds's probe function to .devinit.text A pointer to h1940leds_probe is passed to the core via platform_driver_register and so the function must not disappear when the .init sections are discarded. Otherwise (if also having HOTPLUG=y) unbinding and binding a device to the driver via sysfs will result in an oops as does a device being registered late. An alternative to this patch is using platform_driver_probe instead of platform_driver_register plus removing the pointer to the probe function from the struct platform_driver. Signed-off-by: Uwe Kleine-König Signed-off-by: Richard Purdie --- diff --git a/drivers/leds/leds-h1940.c b/drivers/leds/leds-h1940.c index 11b77a7..1aa46a3 100644 --- a/drivers/leds/leds-h1940.c +++ b/drivers/leds/leds-h1940.c @@ -104,7 +104,7 @@ static struct led_classdev h1940_blueled = { .default_trigger = "h1940-bluetooth", }; -static int __init h1940leds_probe(struct platform_device *pdev) +static int __devinit h1940leds_probe(struct platform_device *pdev) { int ret;