From: Dan Carpenter Date: Wed, 8 Dec 2021 10:33:37 +0000 (+0300) Subject: vdpa: check that offsets are within bounds X-Git-Tag: accepted/tizen/unified/20230118.172025~4210 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=b08b3bfcc720686cd73888ab20111acd9cbfcb19;p=platform%2Fkernel%2Flinux-rpi.git vdpa: check that offsets are within bounds commit 3ed21c1451a14d139e1ceb18f2fa70865ce3195a upstream. In this function "c->off" is a u32 and "size" is a long. On 64bit systems if "c->off" is greater than "size" then "size - c->off" is a negative and we always return -E2BIG. But on 32bit systems the subtraction is type promoted to a high positive u32 value and basically any "c->len" is accepted. Fixes: 4c8cf31885f6 ("vhost: introduce vDPA-based backend") Reported-by: Xie Yongji Signed-off-by: Dan Carpenter Link: https://lore.kernel.org/r/20211208103337.GA4047@kili Signed-off-by: Michael S. Tsirkin Cc: stable@vger.kernel.org Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c index 39039e0..d62f05d 100644 --- a/drivers/vhost/vdpa.c +++ b/drivers/vhost/vdpa.c @@ -197,7 +197,7 @@ static int vhost_vdpa_config_validate(struct vhost_vdpa *v, struct vdpa_device *vdpa = v->vdpa; long size = vdpa->config->get_config_size(vdpa); - if (c->len == 0) + if (c->len == 0 || c->off > size) return -EINVAL; if (c->len > size - c->off)