From: jy910.yun Date: Thu, 16 May 2013 07:16:38 +0000 (+0900) Subject: only delete the unnecessary log in libsysman and system-server X-Git-Tag: submit/tizen_ivi_release/20140401.030119~62 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=b089d1694b6d1f7f3a3504ac51e000a5fe006bb4;p=platform%2Fcore%2Fsystem%2Fsystem-server.git only delete the unnecessary log in libsysman and system-server Change-Id: I7219a7796f9338015af186cf9747cf28ad58bee6 Signed-off-by: jy910.yun --- diff --git a/src/core/sysnoti.c b/src/core/sysnoti.c index 77ddc5a..202d6bc 100644 --- a/src/core/sysnoti.c +++ b/src/core/sysnoti.c @@ -106,10 +106,8 @@ static inline char *recv_str(int fd) _E("Read retry failed"); return NULL; } - if (len <= 0) { - _E("str is null"); + if (len <= 0) return NULL; - } if (len >= INT_MAX) { _E("size is over INT_MAX"); @@ -147,7 +145,6 @@ static inline char *recv_str(int fd) } str[len] = 0; - return str; } diff --git a/sysman/sysconf.c b/sysman/sysconf.c index 5361de7..93a7c61 100644 --- a/sysman/sysconf.c +++ b/sysman/sysconf.c @@ -62,8 +62,7 @@ int util_process_group_set(const char* name, int pid) } snprintf(buf, sizeof(buf), "%d", pid); - ERR("pid(%d) is inserted at vip", pid); - + INFO("pid(%d) is inserted at vip", pid); return sysman_call_predef_action(PROCESS_GROUP_SET, 2, buf, name); } diff --git a/sysman/sysnoti.c b/sysman/sysnoti.c index 7562531..16a2468 100644 --- a/sysman/sysnoti.c +++ b/sysman/sysnoti.c @@ -81,7 +81,6 @@ static inline int send_str(int fd, char *str) static int sysnoti_send(struct sysnoti *msg) { - ERR("--- %s: start", __FUNCTION__); int client_len; int client_sockfd; int result; @@ -115,7 +114,6 @@ static int sysnoti_send(struct sysnoti *msg) for (i = 0; i < msg->argc; i++) send_str(client_sockfd, msg->argv[i]); - ERR("--- %s: read", __FUNCTION__); while (retry_count < RETRY_READ_COUNT) { r = read(client_sockfd, &result, sizeof(int)); if (r < 0) { @@ -136,13 +134,11 @@ static int sysnoti_send(struct sysnoti *msg) } close(client_sockfd); - ERR("--- %s: end", __FUNCTION__); return result; } API int sysman_call_predef_action(const char *type, int num, ...) { - ERR("--- %s: start", __FUNCTION__); struct sysnoti *msg; int ret; va_list argptr; @@ -175,11 +171,9 @@ API int sysman_call_predef_action(const char *type, int num, ...) } va_end(argptr); - ERR("--- %s: send msg", __FUNCTION__); ret = sysnoti_send(msg); free(msg); - ERR("--- %s: end", __FUNCTION__); return ret; } @@ -258,11 +252,11 @@ static int sysnoti_mount_mmc_cb(keynode_t *key_nodes, void *data) if (vconf_keynode_get_int(key_nodes) == VCONFKEY_SYSMAN_MMC_MOUNT_COMPLETED) { DBG("mount ok"); - (mmc_data->mmc_cb)(0, mmc_data->user_data); + (mmc_data->mmc_cb)(0, mmc_data->user_data); } else if (vconf_keynode_get_int(key_nodes) == VCONFKEY_SYSMAN_MMC_MOUNT_ALREADY) { DBG("mount already"); - (mmc_data->mmc_cb)(-2, mmc_data->user_data); + (mmc_data->mmc_cb)(-2, mmc_data->user_data); } else { DBG("mount fail"); vconf_get_int(VCONFKEY_SYSMAN_MMC_ERR_STATUS, &mmc_err); @@ -290,7 +284,7 @@ static int sysnoti_unmount_mmc_cb(keynode_t *key_nodes, void *data) if (vconf_keynode_get_int(key_nodes) == VCONFKEY_SYSMAN_MMC_UNMOUNT_COMPLETED) { DBG("unmount ok"); - (mmc_data->mmc_cb)(0, mmc_data->user_data); + (mmc_data->mmc_cb)(0, mmc_data->user_data); } else { DBG("unmount fail"); vconf_get_int(VCONFKEY_SYSMAN_MMC_ERR_STATUS, &mmc_err); @@ -325,11 +319,10 @@ static int sysnoti_format_mmc_cb(keynode_t *key_nodes, void *data) if (vconf_keynode_get_int(key_nodes) == VCONFKEY_SYSMAN_MMC_FORMAT_COMPLETED) { DBG("format ok"); - (mmc_data->mmc_cb)(0, mmc_data->user_data); - + (mmc_data->mmc_cb)(0, mmc_data->user_data); } else { DBG("format fail"); - (mmc_data->mmc_cb)(-1, mmc_data->user_data); + (mmc_data->mmc_cb)(-1, mmc_data->user_data); } vconf_ignore_key_changed(VCONFKEY_SYSMAN_MMC_FORMAT, (void *)sysnoti_format_mmc_cb); @@ -349,11 +342,9 @@ API int sysman_request_set_cpu_max_frequency(int val) { char buf_pid[8]; char buf_freq[256]; - // to do - need to check new frequncy is valid snprintf(buf_pid, sizeof(buf_pid), "%d", getpid()); snprintf(buf_freq, sizeof(buf_freq), "%d", val * 1000); - return sysman_call_predef_action(PREDEF_SET_MAX_FREQUENCY, 2, buf_pid, buf_freq); } @@ -361,28 +352,22 @@ API int sysman_request_set_cpu_min_frequency(int val) { char buf_pid[8]; char buf_freq[256]; - // to do - need to check new frequncy is valid snprintf(buf_pid, sizeof(buf_pid), "%d", getpid()); snprintf(buf_freq, sizeof(buf_freq), "%d", val * 1000); - return sysman_call_predef_action(PREDEF_SET_MIN_FREQUENCY, 2, buf_pid, buf_freq); } API int sysman_release_cpu_max_frequency() { char buf_pid[8]; - snprintf(buf_pid, sizeof(buf_pid), "%d", getpid()); - return sysman_call_predef_action(PREDEF_RELEASE_MAX_FREQUENCY, 1, buf_pid); } API int sysman_release_cpu_min_frequency() { char buf_pid[8]; - snprintf(buf_pid, sizeof(buf_pid), "%d", getpid()); - return sysman_call_predef_action(PREDEF_RELEASE_MIN_FREQUENCY, 1, buf_pid); }