From: Sakari Ailus Date: Sat, 12 Apr 2014 19:41:12 +0000 (-0300) Subject: [media] smiapp: Fix determining the need for 8-bit read access X-Git-Tag: v5.15~17577^2~250 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=b05cd219ec200c1c91d59011f8692d9b1c166fbc;p=platform%2Fkernel%2Flinux-starfive.git [media] smiapp: Fix determining the need for 8-bit read access 8-bit reads are needed in some cases; however the condition used was wrong. Regular access (register width) was used if: len == SMIAPP_REG_8BIT && !only8 This causes 8-bit read access to be used always. The operator should be || instead: regular access can be used for 8-bit reads OR if allowed otherwise. Signed-off-by: Sakari Ailus Signed-off-by: Mauro Carvalho Chehab --- diff --git a/drivers/media/i2c/smiapp/smiapp-regs.c b/drivers/media/i2c/smiapp/smiapp-regs.c index 5d0151a..c2db205 100644 --- a/drivers/media/i2c/smiapp/smiapp-regs.c +++ b/drivers/media/i2c/smiapp/smiapp-regs.c @@ -172,7 +172,7 @@ static int __smiapp_read(struct smiapp_sensor *sensor, u32 reg, u32 *val, && len != SMIAPP_REG_32BIT) return -EINVAL; - if (len == SMIAPP_REG_8BIT && !only8) + if (len == SMIAPP_REG_8BIT || !only8) rval = ____smiapp_read(sensor, (u16)reg, len, val); else rval = ____smiapp_read_8only(sensor, (u16)reg, len, val);