From: Aditya Pakki Date: Mon, 24 Dec 2018 17:31:13 +0000 (-0600) Subject: misc/ics932s401: Add a missing check to i2c_smbus_read_word_data X-Git-Tag: v5.4-rc1~1512^2~173 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=b05ae01fdb8966afff5b153e7a7ee24684745e2d;p=platform%2Fkernel%2Flinux-rpi.git misc/ics932s401: Add a missing check to i2c_smbus_read_word_data ics932s401_update_device may fail reading in i2c_smbus_read_word_data due to error in i2c_smbus_xfer. The fix checks the status and defaults the register to 0. Signed-off-by: Aditya Pakki Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/misc/ics932s401.c b/drivers/misc/ics932s401.c index 81a0541..294fb2f 100644 --- a/drivers/misc/ics932s401.c +++ b/drivers/misc/ics932s401.c @@ -146,6 +146,8 @@ static struct ics932s401_data *ics932s401_update_device(struct device *dev) */ for (i = 0; i < NUM_MIRRORED_REGS; i++) { temp = i2c_smbus_read_word_data(client, regs_to_copy[i]); + if (temp < 0) + data->regs[regs_to_copy[i]] = 0; data->regs[regs_to_copy[i]] = temp >> 8; }