From: Panu Matilainen <pmatilai@redhat.com>
Date: Fri, 25 Apr 2008 10:54:59 +0000 (+0300)
Subject: Avoid alloca() in rpmInstall()
X-Git-Tag: tznext/4.11.0.1.tizen20130304~4304
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=b046a85409cecc5d7efdb75185fe155e0e3e4293;p=tools%2Flibrpm-tizen.git

Avoid alloca() in rpmInstall()
---

diff --git a/lib/rpminstall.c b/lib/rpminstall.c
index 2b1196a..652dcd2 100644
--- a/lib/rpminstall.c
+++ b/lib/rpminstall.c
@@ -210,7 +210,7 @@ struct rpmEIU {
 /** @todo Generalize --freshen policies. */
 int rpmInstall(rpmts ts, struct rpmInstallArguments_s * ia, ARGV_t fileArgv)
 {
-    struct rpmEIU * eiu = memset(alloca(sizeof(*eiu)), 0, sizeof(*eiu));
+    struct rpmEIU * eiu = xcalloc(1, sizeof(*eiu));
     rpmps ps;
     rpmprobFilterFlags probFilter;
     rpmRelocation * relocations;
@@ -605,6 +605,7 @@ exit:
     eiu->pkgState = _free(eiu->pkgState);
     eiu->pkgURL = _free(eiu->pkgURL);
     eiu->argv = _free(eiu->argv);
+    free(eiu);
 
     rpmtsEmpty(ts);