From: Vaibhav Hiremath Date: Fri, 12 Feb 2016 20:34:18 +0000 (+0530) Subject: greybus: arche-platform: Do not export any gpios X-Git-Tag: v4.9.8~1233^2~378^2~21^2~694 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=b03249390806c48921e1a538673276ebfcb645b7;p=platform%2Fkernel%2Flinux-rpi3.git greybus: arche-platform: Do not export any gpios With addition of operational state in driver, user/developer can switch to FW flashing state through sysfs. So no need to export any gpios to userspace now. Testing Done: Tested on EVT1.2 and DB3.5 platform Signed-off-by: Vaibhav Hiremath Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/greybus/arche-platform.c b/drivers/staging/greybus/arche-platform.c index 037e142..1fd806f 100644 --- a/drivers/staging/greybus/arche-platform.c +++ b/drivers/staging/greybus/arche-platform.c @@ -123,19 +123,6 @@ static void svc_delayed_work(struct work_struct *work) gpio_direction_output(arche_pdata->wake_detect_gpio, 1); } -/* Export gpio's to user space */ -static void export_gpios(struct arche_platform_drvdata *arche_pdata) -{ - gpio_export(arche_pdata->svc_reset_gpio, false); - gpio_export(arche_pdata->svc_sysboot_gpio, false); -} - -static void unexport_gpios(struct arche_platform_drvdata *arche_pdata) -{ - gpio_unexport(arche_pdata->svc_reset_gpio); - gpio_unexport(arche_pdata->svc_sysboot_gpio); -} - static int arche_platform_coldboot_seq(struct arche_platform_drvdata *arche_pdata) { int ret; @@ -383,8 +370,6 @@ static int arche_platform_probe(struct platform_device *pdev) INIT_DELAYED_WORK(&arche_pdata->delayed_work, svc_delayed_work); schedule_delayed_work(&arche_pdata->delayed_work, msecs_to_jiffies(2000)); - export_gpios(arche_pdata); - dev_info(dev, "Device registered successfully\n"); return 0; } @@ -407,7 +392,6 @@ static int arche_platform_remove(struct platform_device *pdev) device_for_each_child(&pdev->dev, NULL, arche_remove_child); arche_platform_poweroff_seq(arche_pdata); platform_set_drvdata(pdev, NULL); - unexport_gpios(arche_pdata); return 0; }