From: Dan Carpenter Date: Wed, 9 Dec 2020 06:50:34 +0000 (+0100) Subject: media: camss: Fix signedness bug in video_enum_fmt() X-Git-Tag: v5.15~1736^2~234 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=b00481bdca2d77fdae5f71517c09fd3b30eba57d;p=platform%2Fkernel%2Flinux-starfive.git media: camss: Fix signedness bug in video_enum_fmt() This test has a problem because we want to know if "k" is -1 or a positive value less than "f->index". But the "f->index" variable is a u32 so if "k == -1" then -1 gets type promoted to UINT_MAX which is larger than "f->index". I've added an explicit test to check for -1. Fixes: a3d412d4b9f3 ("media: Revert "media: camss: Make use of V4L2_CAP_IO_MC"") Signed-off-by: Dan Carpenter Reviewed-by: Robert Foss Reviewed-by: Andrey Konovalov Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab --- diff --git a/drivers/media/platform/qcom/camss/camss-video.c b/drivers/media/platform/qcom/camss/camss-video.c index bd9334a..2fa3214 100644 --- a/drivers/media/platform/qcom/camss/camss-video.c +++ b/drivers/media/platform/qcom/camss/camss-video.c @@ -579,7 +579,7 @@ static int video_enum_fmt(struct file *file, void *fh, struct v4l2_fmtdesc *f) break; } - if (k < f->index) + if (k == -1 || k < f->index) /* * All the unique pixel formats matching the arguments * have been enumerated (k >= 0 and f->index > 0), or