From: Frederic Danis Date: Fri, 23 May 2014 08:04:49 +0000 (+0300) Subject: ath10k: fix ath10k_bmi_read32 macro X-Git-Tag: v3.16~18^2~11^2~7^2~3^2~13 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=afe5b7b4db0c95f22cdcbc02e0b021887faae277;p=platform%2Fkernel%2Flinux-exynos.git ath10k: fix ath10k_bmi_read32 macro tmp may be used uninitialized if ath10k_bmi_read_memory() returns an error. Signed-off-by: Frederic Danis Signed-off-by: Kalle Valo --- diff --git a/drivers/net/wireless/ath/ath10k/bmi.h b/drivers/net/wireless/ath/ath10k/bmi.h index 3a9bdf51..111ab70 100644 --- a/drivers/net/wireless/ath/ath10k/bmi.h +++ b/drivers/net/wireless/ath/ath10k/bmi.h @@ -201,7 +201,8 @@ int ath10k_bmi_write_memory(struct ath10k *ar, u32 address, \ addr = host_interest_item_address(HI_ITEM(item)); \ ret = ath10k_bmi_read_memory(ar, addr, (u8 *)&tmp, 4); \ - *val = __le32_to_cpu(tmp); \ + if (!ret) \ + *val = __le32_to_cpu(tmp); \ ret; \ })