From: Wim Taymans Date: Fri, 21 Dec 2001 00:15:29 +0000 (+0000) Subject: Cleaned up the vorbis plugin X-Git-Tag: start~28 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=afc5bb747d4edd9ef95b787f0e1b335c81cc82a2;p=platform%2Fupstream%2Fgst-plugins-base.git Cleaned up the vorbis plugin Original commit message from CVS: Cleaned up the vorbis plugin - handle EOS. - throw some info to the app. --- diff --git a/ext/vorbis/vorbisdec.c b/ext/vorbis/vorbisdec.c index c68cda3..5c690af 100644 --- a/ext/vorbis/vorbisdec.c +++ b/ext/vorbis/vorbisdec.c @@ -20,83 +20,78 @@ #include #include -/*#define DEBUG_ENABLED */ #include -static void gst_vorbisdec_loop (GstElement *element); +static void gst_vorbisdec_loop (GstElement * element); extern GstPadTemplate *dec_src_template, *dec_sink_template; /* elementfactory information */ -GstElementDetails vorbisdec_details = { +GstElementDetails vorbisdec_details = +{ "Ogg Vorbis decoder", "Filter/Audio/Decoder", "Decodes OGG Vorbis audio", VERSION, - "Monty , "\ + "Monty , " "Wim Taymans ", "(C) 2000", }; -#define VORBIS_INIT 1 -#define VORBIS_HEADER1 2 -#define VORBIS_HEADER2 3 -#define VORBIS_INFO 4 -#define VORBIS_MAIN_LOOP 5 -#define VORBIS_CLEAN 6 -#define VORBIS_EXIT 7 -#define VORBIS_DONE 8 -#define VORBIS_ERROR 9 - /* VorbisDec signals and args */ -enum { +enum +{ /* FILL ME */ LAST_SIGNAL }; -enum { +enum +{ ARG_0, }; -static void gst_vorbisdec_class_init (VorbisDecClass *klass); -static void gst_vorbisdec_init (VorbisDec *vorbisdec); +static void gst_vorbisdec_class_init (VorbisDecClass * klass); +static void gst_vorbisdec_init (VorbisDec * vorbisdec); static GstElementClass *parent_class = NULL; + /*static guint gst_vorbisdec_signals[LAST_SIGNAL] = { 0 }; */ GType -vorbisdec_get_type(void) { +vorbisdec_get_type (void) +{ static GType vorbisdec_type = 0; if (!vorbisdec_type) { static const GTypeInfo vorbisdec_info = { - sizeof(VorbisDecClass), NULL, + sizeof (VorbisDecClass), NULL, NULL, - (GClassInitFunc)gst_vorbisdec_class_init, + (GClassInitFunc) gst_vorbisdec_class_init, NULL, NULL, - sizeof(VorbisDec), + sizeof (VorbisDec), 0, - (GInstanceInitFunc)gst_vorbisdec_init, + (GInstanceInitFunc) gst_vorbisdec_init, }; - vorbisdec_type = g_type_register_static(GST_TYPE_ELEMENT, "VorbisDec", &vorbisdec_info, 0); + + vorbisdec_type = g_type_register_static (GST_TYPE_ELEMENT, "VorbisDec", &vorbisdec_info, 0); } return vorbisdec_type; } static void -gst_vorbisdec_class_init (VorbisDecClass *klass) +gst_vorbisdec_class_init (VorbisDecClass * klass) { GstElementClass *gstelement_class; - gstelement_class = (GstElementClass*)klass; + gstelement_class = (GstElementClass *) klass; - parent_class = g_type_class_ref(GST_TYPE_ELEMENT); + parent_class = g_type_class_ref (GST_TYPE_ELEMENT); } -static void -gst_vorbisdec_init (VorbisDec *vorbisdec) +static void +gst_vorbisdec_init (VorbisDec * vorbisdec) { vorbisdec->sinkpad = gst_pad_new_from_template (dec_sink_template, "sink"); gst_element_add_pad (GST_ELEMENT (vorbisdec), vorbisdec->sinkpad); @@ -105,32 +100,59 @@ gst_vorbisdec_init (VorbisDec *vorbisdec) vorbisdec->srcpad = gst_pad_new_from_template (dec_src_template, "src"); gst_element_add_pad (GST_ELEMENT (vorbisdec), vorbisdec->srcpad); - ogg_sync_init (&vorbisdec->oy); /* Now we can read pages */ - vorbisdec->state = VORBIS_INIT; + ogg_sync_init (&vorbisdec->oy); /* Now we can read pages */ vorbisdec->convsize = 4096; } -static void -gst_vorbisdec_loop (GstElement *element) +static GstBuffer * +gst_vorbisdec_pull (VorbisDec * vorbisdec, ogg_sync_state * oy) +{ + GstBuffer *buf; + + do { + GST_DEBUG (0, "vorbisdec: pull \n"); + + buf = gst_pad_pull (vorbisdec->sinkpad); + + if (GST_IS_EVENT (buf)) { + switch (GST_EVENT_TYPE (buf)) { + case GST_EVENT_FLUSH: + ogg_sync_reset (oy); + case GST_EVENT_EOS: + default: + gst_pad_event_default (vorbisdec->sinkpad, GST_EVENT (buf)); + break; + } + buf = NULL; + } + } while (buf == NULL); + + GST_DEBUG (0, "vorbisdec: pull done\n"); + + return buf; +} + +static void +gst_vorbisdec_loop (GstElement * element) { VorbisDec *vorbisdec; GstBuffer *buf; GstBuffer *outbuf; - ogg_sync_state oy; /* sync and verify incoming physical bitstream */ - ogg_stream_state os; /* take physical pages, weld into a logical - stream of packets */ - ogg_page og; /* one Ogg bitstream page. Vorbis packets are inside */ - ogg_packet op; /* one raw packet of data for decode */ - - vorbis_info vi; /* struct that stores all the static vorbis bitstream - settings */ - vorbis_comment vc; /* struct that stores all the bitstream user comments */ - vorbis_dsp_state vd; /* central working state for the packet->PCM decoder */ - vorbis_block vb; /* local working space for packet->PCM decode */ - + ogg_sync_state oy; /* sync and verify incoming physical bitstream */ + ogg_stream_state os; /* take physical pages, weld into a logical + stream of packets */ + ogg_page og; /* one Ogg bitstream page. Vorbis packets are inside */ + ogg_packet op; /* one raw packet of data for decode */ + + vorbis_info vi; /* struct that stores all the static vorbis bitstream + settings */ + vorbis_comment vc; /* struct that stores all the bitstream user comments */ + vorbis_dsp_state vd; /* central working state for the packet->PCM decoder */ + vorbis_block vb; /* local working space for packet->PCM decode */ + char *buffer; - int bytes; + int bytes; g_return_if_fail (element != NULL); g_return_if_fail (GST_IS_VORBISDEC (element)); @@ -138,12 +160,11 @@ gst_vorbisdec_loop (GstElement *element) vorbisdec = GST_VORBISDEC (element); /********** Decode setup ************/ - ogg_sync_init (&oy); /* Now we can read pages */ - - while(1){ /* we repeat if the bitstream is chained */ - int eos=0; + ogg_sync_init (&oy); /* Now we can read pages */ + + while (1) { /* we repeat if the bitstream is chained */ + int eos = 0; int i; - gboolean need_sync = FALSE; /* grab some data at the head of the stream. We want the first page (which is guaranteed to be small and only contain the Vorbis @@ -152,305 +173,280 @@ gst_vorbisdec_loop (GstElement *element) /* FIXME HACK! trap COTHREAD_STOPPING here */ if (GST_ELEMENT_IS_COTHREAD_STOPPING (vorbisdec)) { - GST_DEBUG(0, "HACK HACK HACK, switching to cothread zero on COTHREAD_STOPPING\n"); - cothread_switch(cothread_current_main()); + GST_DEBUG (0, "HACK HACK HACK, switching to cothread zero on COTHREAD_STOPPING\n"); + cothread_switch (cothread_current_main ()); } /* submit a 4k block to libvorbis' Ogg layer */ - GST_DEBUG (0,"vorbisdec: pull\n"); - buf = gst_pad_pull (vorbisdec->sinkpad); + buf = gst_vorbisdec_pull (vorbisdec, &oy); - if (GST_BUFFER_FLAG_IS_SET (buf, GST_BUFFER_FLUSH)) { - /*g_print("reset\n"); */ - ogg_sync_reset(&oy); - need_sync = TRUE; - } - GST_DEBUG (0,"vorbisdec: pull done\n"); bytes = GST_BUFFER_SIZE (buf); - buffer = ogg_sync_buffer (&oy, bytes); memcpy (buffer, GST_BUFFER_DATA (buf), bytes); - ogg_sync_wrote(&oy,bytes); - + ogg_sync_wrote (&oy, bytes); + /* Get the first page. */ - if(ogg_sync_pageout (&oy, &og)!=1){ - /* have we simply run out of data? If so, we're done. */ - if (GST_BUFFER_FLAG_IS_SET (buf, GST_BUFFER_EOS)) { - gst_buffer_unref (buf); - break; - } - + if (ogg_sync_pageout (&oy, &og) != 1) { /* error case. Must not be Vorbis data */ - GST_DEBUG (0,"Input does not appear to be an Ogg bitstream.\n"); -/* FIXME */ -/* exit(1); */ + g_warning ("Input does not appear to be an Ogg bitstream.\n"); } gst_buffer_unref (buf); - + /* Get the serial number and set up the rest of decode. */ /* serialno first; use it to set up a logical stream */ ogg_stream_init (&os, ogg_page_serialno (&og)); - + /* extract the initial header from the first page and verify that the Ogg bitstream is in fact Vorbis data */ - + /* I handle the initial header first instead of just having the code read all three Vorbis headers at once because reading the initial header is an easy way to identify a Vorbis bitstream and it's useful to see that functionality seperated out. */ - + vorbis_info_init (&vi); vorbis_comment_init (&vc); - if(ogg_stream_pagein (&os, &og) < 0){ + if (ogg_stream_pagein (&os, &og) < 0) { /* error; stream version mismatch perhaps */ - printf("Error reading first page of Ogg bitstream data.\n"); -/* FIXME */ -/* exit(1); */ + g_warning ("Error reading first page of Ogg bitstream data.\n"); } - - if(ogg_stream_packetout (&os, &op) != 1){ + + if (ogg_stream_packetout (&os, &op) != 1) { /* no page? must not be vorbis */ - printf("Error reading initial header packet.\n"); -/* FIXME */ -/* exit(1); */ + g_warning ("Error reading initial header packet.\n"); } - - if(vorbis_synthesis_headerin (&vi, &vc,&op) < 0){ + + if (vorbis_synthesis_headerin (&vi, &vc, &op) < 0) { /* error case; not a vorbis header */ - printf("This Ogg bitstream does not contain Vorbis " - "audio data.\n"); -/* FIXME */ -/* exit(1); */ + g_warning ("This Ogg bitstream does not contain Vorbis " "audio data.\n"); } - + /* At this point, we're sure we're Vorbis. We've set up the logical (Ogg) bitstream decoder. Get the comment and codebook headers and set up the Vorbis decoder */ - + /* The next two packets in order are the comment and codebook headers. They're likely large and may span multiple pages. Thus we reead and submit data until we get our two pacakets, watching that no pages are missing. If a page is missing, error out; losing a header page is the only place where missing data is fatal. */ - - i=0; - while(i<2){ - while(i<2){ + + i = 0; + while (i < 2) { + while (i < 2) { int result = ogg_sync_pageout (&oy, &og); - if (result == 0) break; /* Need more data */ + + if (result == 0) + break; /* Need more data */ /* Don't complain about missing or corrupt data yet. We'll catch it at the packet output phase */ if (result == 1) { - ogg_stream_pagein (&os, &og); /* we can ignore any errors here - as they'll also become apparent - at packetout */ - while(i<2){ + ogg_stream_pagein (&os, &og); /* we can ignore any errors here + as they'll also become apparent + at packetout */ + while (i < 2) { result = ogg_stream_packetout (&os, &op); - if (result == 0) break; - if (result == -1){ + if (result == 0) + break; + if (result == -1) { /* Uh oh; data at some point was corrupted or missing! - We can't tolerate that in a header. Die. */ - printf("Corrupt secondary header. Exiting.\n"); -/* FIXME */ -/* exit(1); */ + We can't tolerate that in a header. Die. */ + g_warning ("Corrupt secondary header. expect trouble\n"); } vorbis_synthesis_headerin (&vi, &vc, &op); i++; } } } - /* no harm in not checking before adding more */ + /* no harm in not checkiindent: Standard input:375: Warning:old style assignment ambiguity in "=-". Assuming "= -" + +ng before adding more */ /* FIXME HACK! trap COTHREAD_STOPPING here */ if (GST_ELEMENT_IS_COTHREAD_STOPPING (vorbisdec)) { - GST_DEBUG(0, "HACK HACK HACK, switching to cothread zero on COTHREAD_STOPPING\n"); - cothread_switch(cothread_current_main()); + GST_DEBUG (0, "HACK HACK HACK, switching to cothread zero on COTHREAD_STOPPING\n"); + cothread_switch (cothread_current_main ()); } - GST_DEBUG (0,"vorbisdec: pull\n"); - buf = gst_pad_pull (vorbisdec->sinkpad); - if (GST_BUFFER_FLAG_IS_SET (buf, GST_BUFFER_FLUSH)) { - /*g_print("reset\n"); */ - ogg_sync_reset(&oy); - need_sync = TRUE; - } - GST_DEBUG (0,"vorbisdec: pull done\n"); + buf = gst_vorbisdec_pull (vorbisdec, &oy); bytes = GST_BUFFER_SIZE (buf); buffer = ogg_sync_buffer (&oy, bytes); memcpy (buffer, GST_BUFFER_DATA (buf), bytes); gst_buffer_unref (buf); - if(bytes==0 && i < 2){ - fprintf(stderr,"End of file before finding all Vorbis headers!\n"); -/* FIXME */ -/* exit(1); */ + if (bytes == 0 && i < 2) { + g_warning ("End of file before finding all Vorbis headers! expect trouble..\n"); } ogg_sync_wrote (&oy, bytes); } - + /* Throw the comments plus a few lines about the bitstream we're decoding */ { char **ptr = vc.user_comments; - while(*ptr){ - GST_INFO (GST_CAT_PLUGIN_INFO, "vorbisdec: %s\n",*ptr); + + while (*ptr) { + gst_element_send_event (GST_ELEMENT (vorbisdec), + gst_event_new_info ("comment", GST_PROPS_STRING (*ptr), NULL)); ++ptr; } - GST_INFO (GST_CAT_PLUGIN_INFO, "vorbisdec: Bitstream is %d channel, %ldHz", vi.channels, vi.rate); - GST_INFO (GST_CAT_PLUGIN_INFO, "vorbisdec: Encoded by: %s", vc.vendor); + gst_element_send_event (GST_ELEMENT (vorbisdec), + gst_event_new_info ("vendor", GST_PROPS_STRING (vc.vendor), NULL)); + + gst_element_send_event (GST_ELEMENT (vorbisdec), + gst_event_new_info ("version", GST_PROPS_INT (vi.version), NULL)); + gst_element_send_event (GST_ELEMENT (vorbisdec), + gst_event_new_info ("channels", GST_PROPS_INT (vi.channels), NULL)); + gst_element_send_event (GST_ELEMENT (vorbisdec), + gst_event_new_info ("rate", GST_PROPS_INT (vi.rate), NULL)); + gst_element_send_event (GST_ELEMENT (vorbisdec), + gst_event_new_info ("bitrate_upper", GST_PROPS_INT (vi.bitrate_upper), NULL)); + gst_element_send_event (GST_ELEMENT (vorbisdec), + gst_event_new_info ("bitrate_nominal", GST_PROPS_INT (vi.bitrate_nominal), NULL)); + gst_element_send_event (GST_ELEMENT (vorbisdec), + gst_event_new_info ("bitrate_lower", GST_PROPS_INT (vi.bitrate_lower), NULL)); + gst_element_send_event (GST_ELEMENT (vorbisdec), + gst_event_new_info ("bitrate_window", GST_PROPS_INT (vi.bitrate_window), NULL)); } - gst_pad_set_caps (vorbisdec->srcpad, - gst_caps_new ( - "vorbisdec_src", - "audio/raw", - gst_props_new ( - "format", GST_PROPS_STRING ("int"), - "law", GST_PROPS_INT (0), - "endianness", GST_PROPS_INT (G_BYTE_ORDER), - "signed", GST_PROPS_BOOLEAN (TRUE), - "width", GST_PROPS_INT (16), - "depth", GST_PROPS_INT (16), - "rate", GST_PROPS_INT (vi.rate), - "channels", GST_PROPS_INT (vi.channels), - NULL - ))); - - vorbisdec->convsize = 4096/vi.channels; + gst_pad_set_caps (vorbisdec->srcpad, + gst_caps_new ("vorbisdec_src", + "audio/raw", + gst_props_new ("format", GST_PROPS_STRING ("int"), + "law", GST_PROPS_INT (0), + "endianness", GST_PROPS_INT (G_BYTE_ORDER), + "signed", GST_PROPS_BOOLEAN (TRUE), + "width", GST_PROPS_INT (16), + "depth", GST_PROPS_INT (16), + "rate", GST_PROPS_INT (vi.rate), + "channels", GST_PROPS_INT (vi.channels), + NULL))); + + vorbisdec->convsize = 4096 / vi.channels; /* OK, got and parsed all three headers. Initialize the Vorbis packet->PCM decoder. */ - vorbis_synthesis_init (&vd, &vi); /* central decode state */ - vorbis_block_init (&vd, &vb); /* local state for most of the decode - so multiple block decodes can - proceed in parallel. We could init - multiple vorbis_block structures - for vd here */ - + vorbis_synthesis_init (&vd, &vi); /* central decode state */ + vorbis_block_init (&vd, &vb); /* local state for most of the decode + so multiple block decodes can + proceed in parallel. We could init + multiple vorbis_block structures + for vd here */ + /* The rest is just a straight decode loop until end of stream */ while (!eos) { while (!eos) { int result = ogg_sync_pageout (&oy, &og); - if (result ==0) break; /* need more data */ - if (result ==-1) { /* missing or corrupt data at this page position */ - } else { - ogg_stream_pagein (&os, &og); /* can safely ignore errors at - this point */ + + if (result == 0) + break; /* need more data */ + if (result == -1) { /* missing or corrupt data at this page position */ + } + else { + ogg_stream_pagein (&os, &og); /* can safely ignore errors at + this point */ while (1) { - result=ogg_stream_packetout (&os, &op); + result = ogg_stream_packetout (&os, &op); - if (result == 0) break; /* need more data */ - if (result == -1) { /* missing or corrupt data at this page position */ + if (result == 0) + break; /* need more data */ + if (result == -1) { /* missing or corrupt data at this page position */ /* no reason to complain; already complained above */ - } else { + } + else { /* we have a packet. Decode it */ float **pcm; int samples; - - if (vorbis_synthesis (&vb, &op) == 0) /* test for success! */ - vorbis_synthesis_blockin (&vd, &vb); + if (vorbis_synthesis (&vb, &op) == 0) /* test for success! */ + vorbis_synthesis_blockin (&vd, &vb); /* - - **pcm is a multichannel double vector. In stereo, for - example, pcm[0] is left, and pcm[1] is right. samples is - the size of each channel. Convert the float values - (-1.<=range<=1.) to whatever PCM format and write it out */ - + **pcm is a multichannel double vector. In stereo, for + example, pcm[0] is left, and pcm[1] is right. samples is + the size of each channel. Convert the float values + (-1.<=range<=1.) to whatever PCM format and write it out */ + while ((samples = vorbis_synthesis_pcmout (&vd, &pcm)) > 0) { int j; int clipflag = 0; int bout = (samples < vorbisdec->convsize ? samples : vorbisdec->convsize); - + outbuf = gst_buffer_new (); - GST_BUFFER_DATA (outbuf) = g_malloc (2*vi.channels * bout); - GST_BUFFER_SIZE (outbuf) = 2*vi.channels * bout; + GST_BUFFER_DATA (outbuf) = g_malloc (2 * vi.channels * bout); + GST_BUFFER_SIZE (outbuf) = 2 * vi.channels * bout; /* convert doubles to 16 bit signed ints (host order) and interleave */ - for (i=0; i32767){ - val=32767; - clipflag=1; + if (val > 32767) { + val = 32767; + clipflag = 1; } - if (val<-32768){ - val=-32768; - clipflag=1; + if (val < -32768) { + val = -32768; + clipflag = 1; } - *ptr=val; - ptr+=vi.channels; + *ptr = val; + ptr += vi.channels; } } - - if (need_sync) { - GST_BUFFER_FLAG_SET (outbuf, GST_BUFFER_FLUSH); - need_sync = FALSE; - } - GST_DEBUG (0,"vorbisdec: push\n"); + GST_DEBUG (0, "vorbisdec: push\n"); gst_pad_push (vorbisdec->srcpad, outbuf); - GST_DEBUG (0,"vorbisdec: push done\n"); - - vorbis_synthesis_read (&vd, bout); /* tell libvorbis how - many samples we - actually consumed */ - } + GST_DEBUG (0, "vorbisdec: push done\n"); + + vorbis_synthesis_read (&vd, bout); /* tell libvorbis how + many samples we + actually consumed */ + } } } - if (ogg_page_eos (&og)) eos=1; + if (ogg_page_eos (&og)) + eos = 1; } } if (!eos) { /* FIXME HACK! trap COTHREAD_STOPPING here */ if (GST_ELEMENT_IS_COTHREAD_STOPPING (vorbisdec)) { - GST_DEBUG(0, "HACK HACK HACK, switching to cothread zero on COTHREAD_STOPPING\n"); - cothread_switch(cothread_current_main()); + GST_DEBUG (0, "HACK HACK HACK, switching to cothread zero on COTHREAD_STOPPING\n"); + cothread_switch (cothread_current_main ()); } - GST_DEBUG (0,"vorbisdec: pull\n"); - buf = gst_pad_pull (vorbisdec->sinkpad); - if (GST_BUFFER_FLAG_IS_SET (buf, GST_BUFFER_FLUSH)) { - /*g_print("reset\n"); */ - ogg_sync_reset(&oy); - need_sync = TRUE; - } - GST_DEBUG (0,"vorbisdec: pull done\n"); - bytes = GST_BUFFER_SIZE (buf); + buf = gst_vorbisdec_pull (vorbisdec, &oy); + bytes = GST_BUFFER_SIZE (buf); buffer = ogg_sync_buffer (&oy, bytes); - memcpy (buffer, GST_BUFFER_DATA (buf), bytes); + memcpy (buffer, GST_BUFFER_DATA (buf), bytes); gst_buffer_unref (buf); ogg_sync_wrote (&oy, bytes); if (bytes == 0) { - g_print("vorbisdec: eos reached\n"); - eos=1; + eos = 1; } } } - + /* clean up this logical bitstream; before exit we see if we're followed by another [chained] */ ogg_stream_clear (&os); - + /* ogg_page and ogg_packet structs always point to storage in libvorbis. They're never freed or manipulated directly */ - + vorbis_block_clear (&vb); vorbis_dsp_clear (&vd); - vorbis_info_clear (&vi); /* must be called last */ + vorbis_info_clear (&vi); /* must be called last */ } /* OK, clean up the framer */ ogg_sync_clear (&oy); - - g_print("vorbisdec: end\n"); } - diff --git a/ext/vorbis/vorbisdec.h b/ext/vorbis/vorbisdec.h index 96f3c42..2de17e9 100644 --- a/ext/vorbis/vorbisdec.h +++ b/ext/vorbis/vorbisdec.h @@ -64,7 +64,6 @@ struct _VorbisDec { vorbis_block vb; /* local working space for packet->PCM decode */ gboolean eos; - guint state; int16_t convsize; };