From: Rui Ueyama Date: Fri, 30 Jan 2015 01:52:23 +0000 (+0000) Subject: Explicitly write type instead of auto. X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=afbe58f88b7d4710e1b921f1437b45f243322802;p=platform%2Fupstream%2Fllvm.git Explicitly write type instead of auto. Now it is clear that std::move() is meaningless here. llvm-svn: 227543 --- diff --git a/lld/include/lld/Core/Simple.h b/lld/include/lld/Core/Simple.h index 789fd44..e13c0f4 100644 --- a/lld/include/lld/Core/Simple.h +++ b/lld/include/lld/Core/Simple.h @@ -80,14 +80,14 @@ protected: class SimpleFileWrapper : public SimpleFile { public: SimpleFileWrapper(const File &file) : SimpleFile(file.path()) { - for (auto definedAtom : file.defined()) - _definedAtoms._atoms.push_back(std::move(definedAtom)); - for (auto undefAtom : file.undefined()) - _undefinedAtoms._atoms.push_back(std::move(undefAtom)); - for (auto shlibAtom : file.sharedLibrary()) - _sharedLibraryAtoms._atoms.push_back(std::move(shlibAtom)); - for (auto absAtom : file.absolute()) - _absoluteAtoms._atoms.push_back(std::move(absAtom)); + for (const DefinedAtom *atom : file.defined()) + _definedAtoms._atoms.push_back(atom); + for (const UndefinedAtom *atom : file.undefined()) + _undefinedAtoms._atoms.push_back(atom); + for (const SharedLibraryAtom *atom : file.sharedLibrary()) + _sharedLibraryAtoms._atoms.push_back(atom); + for (const AbsoluteAtom *atom : file.absolute()) + _absoluteAtoms._atoms.push_back(atom); } };