From: Paul Gortmaker Date: Tue, 21 Jan 2014 23:48:46 +0000 (-0800) Subject: fs/ramfs: don't use module_init for non-modular core code X-Git-Tag: v3.14-rc1~134^2~90 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=af52b040eba5e6982d8665af8cd4dd69a466d5c3;p=platform%2Fkernel%2Flinux-stable.git fs/ramfs: don't use module_init for non-modular core code The ramfs is always built in. It will never be modular, so using module_init as an alias for __initcall is rather misleading. Fix this up now, so that we can relocate module_init from init.h into module.h in the future. If we don't do this, we'd have to add module.h to obviously non-modular code, and that would be a worse thing. Note that direct use of __initcall is discouraged, vs. one of the priority categorized subgroups. As __initcall gets mapped onto device_initcall, our use of fs_initcall (which makes sense for fs code) will thus change this registration from level 6-device to level 5-fs (i.e. slightly earlier). However no observable impact of that small difference has been observed during testing, or is expected. Also note that this change uncovers a missing semicolon bug in the registration of the initcall. Signed-off-by: Paul Gortmaker Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds --- diff --git a/fs/ramfs/inode.c b/fs/ramfs/inode.c index 39d1465..6a3e2c4 100644 --- a/fs/ramfs/inode.c +++ b/fs/ramfs/inode.c @@ -275,4 +275,4 @@ int __init init_ramfs_fs(void) return err; } -module_init(init_ramfs_fs) +fs_initcall(init_ramfs_fs);