From: Tim-Philipp Müller <tim@centricular.com>
Date: Fri, 27 Feb 2015 01:26:24 +0000 (+0000)
Subject: ges-base-xml-formatter: fix setting of child properties
X-Git-Tag: 1.19.3~493^2~1269
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=af3fd19637d0a4d4d24e5fde964e17271efc9dcd;p=platform%2Fupstream%2Fgstreamer.git

ges-base-xml-formatter: fix setting of child properties

Make sure all child properties get set. GstStructureForeachFunc
takes a gboolean return value that decides whether to
continue or not.
---

diff --git a/ges/ges-base-xml-formatter.c b/ges/ges-base-xml-formatter.c
index 6f81f94..7b78d01 100644
--- a/ges/ges-base-xml-formatter.c
+++ b/ges/ges-base-xml-formatter.c
@@ -479,20 +479,22 @@ _loading_done_cb (GESFormatter * self)
   return FALSE;
 }
 
-static void
+static gboolean
 _set_child_property (GQuark field_id, const GValue * value,
     GESTrackElement * effect)
 {
   GParamSpec *pspec;
   GstElement *element;
 
+  /* FIXME: error handling? */
   if (!ges_track_element_lookup_child (effect,
           g_quark_to_string (field_id), &element, &pspec))
-    return;
+    return TRUE;
 
   g_object_set_property (G_OBJECT (element), pspec->name, value);
   g_param_spec_unref (pspec);
   gst_object_unref (element);
+  return TRUE;
 }
 
 gboolean