From: Mel Gorman Date: Thu, 19 Dec 2013 01:08:45 +0000 (-0800) Subject: mm: numa: guarantee that tlb_flush_pending updates are visible before page table... X-Git-Tag: upstream/snapshot3+hdmi~3754^2~11 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=af2c1401e6f9177483be4fad876d0073669df9df;p=platform%2Fadaptation%2Frenesas_rcar%2Frenesas_kernel.git mm: numa: guarantee that tlb_flush_pending updates are visible before page table updates According to documentation on barriers, stores issued before a LOCK can complete after the lock implying that it's possible tlb_flush_pending can be visible after a page table update. As per revised documentation, this patch adds a smp_mb__before_spinlock to guarantee the correct ordering. Signed-off-by: Mel Gorman Acked-by: Paul E. McKenney Reviewed-by: Rik van Riel Cc: Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds --- diff --git a/include/linux/mm_types.h b/include/linux/mm_types.h index e5c49c3..ad0616f 100644 --- a/include/linux/mm_types.h +++ b/include/linux/mm_types.h @@ -482,7 +482,12 @@ static inline bool mm_tlb_flush_pending(struct mm_struct *mm) static inline void set_tlb_flush_pending(struct mm_struct *mm) { mm->tlb_flush_pending = true; - barrier(); + + /* + * Guarantee that the tlb_flush_pending store does not leak into the + * critical section updating the page tables + */ + smp_mb__before_spinlock(); } /* Clearing is done after a TLB flush, which also provides a barrier. */ static inline void clear_tlb_flush_pending(struct mm_struct *mm)