From: Andy Shevchenko Date: Mon, 11 Apr 2022 18:07:52 +0000 (+0300) Subject: i2c: dev: Force case user pointers in compat_i2cdev_ioctl() X-Git-Tag: v6.6.17~7728^2~1 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=aef80e2fbe3ec6264e935cebfb8fa3367cb1e7b0;p=platform%2Fkernel%2Flinux-rpi.git i2c: dev: Force case user pointers in compat_i2cdev_ioctl() Sparse has warned us about wrong address space for user pointers: i2c-dev.c:561:50: warning: incorrect type in initializer (different address spaces) i2c-dev.c:561:50: expected unsigned char [usertype] *buf i2c-dev.c:561:50: got void [noderef] __user * Force cast the pointer to (__u8 *) that is used by I²C core code. Note, this is an additional fix to the previously addressed similar issue in the I2C_RDWR case in the same function. Fixes: 3265a7e6b41b ("i2c: dev: Add __user annotation") Signed-off-by: Andy Shevchenko Signed-off-by: Wolfram Sang --- diff --git a/drivers/i2c/i2c-dev.c b/drivers/i2c/i2c-dev.c index 6fd2b67..ab0adaa 100644 --- a/drivers/i2c/i2c-dev.c +++ b/drivers/i2c/i2c-dev.c @@ -557,7 +557,7 @@ static long compat_i2cdev_ioctl(struct file *file, unsigned int cmd, unsigned lo .addr = umsg.addr, .flags = umsg.flags, .len = umsg.len, - .buf = compat_ptr(umsg.buf) + .buf = (__force __u8 *)compat_ptr(umsg.buf), }; }