From: Antoine Tenart Date: Wed, 19 Sep 2018 09:39:31 +0000 (+0200) Subject: net: phy: phylink: ensure the carrier is off when starting phylink X-Git-Tag: v5.15~7641^2~327^2~2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=aeeb2e8fdefdd5d257a1446351c70cb3df540199;p=platform%2Fkernel%2Flinux-starfive.git net: phy: phylink: ensure the carrier is off when starting phylink Phylink made an assumption about the carrier state being down when calling phylink_start(). If this assumption isn't satisfied, the internal phylink state could misbehave and a net device could end up not being functional. This patch fixes this by explicitly calling netif_carrier_off() in phylink_start(). Signed-off-by: Antoine Tenart Acked-by: Russell King Signed-off-by: David S. Miller --- diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c index 3ba5cf2..1d01e0c 100644 --- a/drivers/net/phy/phylink.c +++ b/drivers/net/phy/phylink.c @@ -901,6 +901,9 @@ void phylink_start(struct phylink *pl) phylink_an_mode_str(pl->link_an_mode), phy_modes(pl->link_config.interface)); + /* Always set the carrier off */ + netif_carrier_off(pl->netdev); + /* Apply the link configuration to the MAC when starting. This allows * a fixed-link to start with the correct parameters, and also * ensures that we set the appropriate advertisement for Serdes links.