From: Jim Meyering Date: Sun, 3 Apr 2011 14:37:45 +0000 (+0200) Subject: tests: preserve-gid: don't chown temporary PATH dir to a nameless UID X-Git-Tag: v8.11~18 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=aec3e1e107b9104d188fc8494426bd8fb15b1741;p=platform%2Fupstream%2Fcoreutils.git tests: preserve-gid: don't chown temporary PATH dir to a nameless UID * tests/cp/preserve-gid: Simply chmod a+rx instead. That is safer, in case the nameless UID actually has an account, and might take advantage of root running a program in a directory under its control --- diff --git a/tests/cp/preserve-gid b/tests/cp/preserve-gid index 4b80fa7..de4bc5b 100755 --- a/tests/cp/preserve-gid +++ b/tests/cp/preserve-gid @@ -103,9 +103,14 @@ t0 c1 0 "$nameless_gid2" cp -p # $nameless_uid can access it and then make that directory the search path. tmp_path= cleanup_() { rm -rf "$tmp_path"; } + +# Cause mktemp to create a directory directly under /tmp. +# Setting TMPDIR explicitly is required here, in case $TMPDIR +# is not readable by our nameless IDs. +test -d /tmp && TMPDIR=/tmp tmp_path=$(mktemp -d) || fail_ "failed to create temporary directory" cp "$abs_path_dir_/cp" "$tmp_path" -chown -R $nameless_uid "$tmp_path" +chmod -R a+rx "$tmp_path" t1() { f=$1; shift