From: Nick Clifton <nickc@redhat.com>
Date: Wed, 9 Oct 2013 16:17:23 +0000 (+0000)
Subject: 	PR binutils/16024
X-Git-Tag: binutils_latest_snapshot~109
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=aebcf7b7ec8e87eb07bbdef37dafac0b499e35cb;p=external%2Fbinutils.git

	PR binutils/16024
	* objdump.c (usage): Mark as a no-return function.
	(main): Add comment explaining why a break statement is not
	needed.
---

diff --git a/binutils/ChangeLog b/binutils/ChangeLog
index 2bebf99..48d3f0b 100644
--- a/binutils/ChangeLog
+++ b/binutils/ChangeLog
@@ -1,5 +1,10 @@
 2013-10-09  Nick Clifton  <nickc@redhat.com>
 
+	PR binutils/16024
+	* objdump.c (usage): Mark as a no-return function.
+	(main): Add comment explaining why a break statement is not
+	needed.
+
 	* dwarf.c (add64): New function.
 	(read_and_display_attr_value): Add CU offset in to the value
 	displayed for a DW_AT_ref8 attribute.
diff --git a/binutils/objdump.c b/binutils/objdump.c
index 89efc15..37962cb 100644
--- a/binutils/objdump.c
+++ b/binutils/objdump.c
@@ -1,7 +1,5 @@
 /* objdump.c -- dump information about an object file.
-   Copyright 1990, 1991, 1992, 1993, 1994, 1995, 1996, 1997, 1998, 1999,
-   2000, 2001, 2002, 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011,
-   2012, 2013 Free Software Foundation, Inc.
+   Copyright 1990-2013 Free Software Foundation, Inc.
 
    This file is part of GNU Binutils.
 
@@ -193,6 +191,7 @@ static const struct objdump_private_desc * const objdump_private_vectors[] =
     NULL
   };
 
+static void usage (FILE *, int) ATTRIBUTE_NORETURN;
 static void
 usage (FILE *stream, int status)
 {
@@ -3657,15 +3656,15 @@ main (int argc, char **argv)
 	  dump_section_headers = TRUE;
 	  seenflag = TRUE;
 	  break;
-	case 'H':
-	  usage (stdout, 0);
-	  seenflag = TRUE;
 	case 'v':
 	case 'V':
 	  show_version = TRUE;
 	  seenflag = TRUE;
 	  break;
 
+	case 'H':
+	  usage (stdout, 0);
+	  /* No need to set seenflag or to break - usage() does not return.  */
 	default:
 	  usage (stderr, 1);
 	}