From: Jeff Garzik Date: Tue, 17 Jul 2007 05:08:29 +0000 (-0400) Subject: drivers/usb/misc/auerswald: fix status check, remove redundant check X-Git-Tag: v2.6.23-rc1~515^2~7 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=ae97fec3701a559929c3529e35417fab133a4d39;p=platform%2Fkernel%2Flinux-exynos.git drivers/usb/misc/auerswald: fix status check, remove redundant check 1) We should only set 'actual_length' output variable if usb length is known to be good. 2) No need to check actual_length for NULL. The only caller always passes non-NULL value. Signed-off-by: Jeff Garzik --- diff --git a/drivers/usb/misc/auerswald.c b/drivers/usb/misc/auerswald.c index 1fd5fc2..3e22b2f 100644 --- a/drivers/usb/misc/auerswald.c +++ b/drivers/usb/misc/auerswald.c @@ -630,7 +630,7 @@ static int auerchain_start_wait_urb (pauerchain_t acp, struct urb *urb, int time } else status = urb->status; - if (actual_length) + if (status >= 0) *actual_length = urb->actual_length; return status;