From: Dan Carpenter Date: Fri, 4 Dec 2020 14:23:00 +0000 (+0300) Subject: virtio_ring: Cut and paste bugs in vring_create_virtqueue_packed() X-Git-Tag: accepted/tizen/unified/20230118.172025~8132^2~8 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=ae93d8ea0fa701e84ab9df0db9fb60ec6c80d7b8;p=platform%2Fkernel%2Flinux-rpi.git virtio_ring: Cut and paste bugs in vring_create_virtqueue_packed() There is a copy and paste bug in the error handling of this code and it uses "ring_dma_addr" three times instead of "device_event_dma_addr" and "driver_event_dma_addr". Fixes: 1ce9e6055fa0 (" virtio_ring: introduce packed ring support") Reported-by: Robert Buhren Reported-by: Felicitas Hetzelt Signed-off-by: Dan Carpenter Link: https://lore.kernel.org/r/X8pGRJlEzyn+04u2@mwanda Signed-off-by: Michael S. Tsirkin Acked-by: Jason Wang --- diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c index becc776..924b6b8 100644 --- a/drivers/virtio/virtio_ring.c +++ b/drivers/virtio/virtio_ring.c @@ -1676,9 +1676,9 @@ err_desc_extra: err_desc_state: kfree(vq); err_vq: - vring_free_queue(vdev, event_size_in_bytes, device, ring_dma_addr); + vring_free_queue(vdev, event_size_in_bytes, device, device_event_dma_addr); err_device: - vring_free_queue(vdev, event_size_in_bytes, driver, ring_dma_addr); + vring_free_queue(vdev, event_size_in_bytes, driver, driver_event_dma_addr); err_driver: vring_free_queue(vdev, ring_size_in_bytes, ring, ring_dma_addr); err_ring: