From: Dan Carpenter Date: Tue, 25 Sep 2012 07:02:51 +0000 (+0300) Subject: remoteproc: snprintf() can return more than was printed X-Git-Tag: upstream/snapshot3+hdmi~6536^2~4 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=ae768d5fac18cd4b3ff51a4860b89fabba8ccc65;p=platform%2Fadaptation%2Frenesas_rcar%2Frenesas_kernel.git remoteproc: snprintf() can return more than was printed snprintf() returns the number of characters which would have been printed if there were enough space. For example, on the first print if we fill up the 28 character string then it would return a number more than 30. Use scnprintf() instead because that returns the actual number of characters printed. Signed-off-by: Dan Carpenter Signed-off-by: Ohad Ben-Cohen --- diff --git a/drivers/remoteproc/remoteproc_debugfs.c b/drivers/remoteproc/remoteproc_debugfs.c index 10a3825..ea90a56 100644 --- a/drivers/remoteproc/remoteproc_debugfs.c +++ b/drivers/remoteproc/remoteproc_debugfs.c @@ -82,7 +82,7 @@ static ssize_t rproc_state_read(struct file *filp, char __user *userbuf, state = rproc->state > RPROC_LAST ? RPROC_LAST : rproc->state; - i = snprintf(buf, 30, "%.28s (%d)\n", rproc_state_string[state], + i = scnprintf(buf, 30, "%.28s (%d)\n", rproc_state_string[state], rproc->state); return simple_read_from_buffer(userbuf, count, ppos, buf, i); @@ -103,7 +103,7 @@ static ssize_t rproc_name_read(struct file *filp, char __user *userbuf, char buf[100]; int i; - i = snprintf(buf, sizeof(buf), "%.98s\n", rproc->name); + i = scnprintf(buf, sizeof(buf), "%.98s\n", rproc->name); return simple_read_from_buffer(userbuf, count, ppos, buf, i); }