From: Seung-Woo Kim <sw0312.kim@samsung.com>
Date: Wed, 6 Nov 2024 09:05:06 +0000 (+0900)
Subject: net: wireless: rtl8723ds: Fix wrong casting for function pointer
X-Git-Tag: accepted/tizen/unified/x/20241108.051654~2
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=ae6d50cb15baf7d6c9a5b77dc40fabc3e82173b0;p=platform%2Fkernel%2Flinux-thead.git

net: wireless: rtl8723ds: Fix wrong casting for function pointer

Instead of wrong function pointer casting, cast argument from
the callback function.

Change-Id: Ie3e2db6803a40fb61b1e4f7978c0a996952a2996
Signed-off-by: Seung-Woo Kim <sw0312.kim@samsung.com>
---

diff --git a/drivers/net/wireless/rtl8723ds/hal/rtl8723d/sdio/rtl8723ds_recv.c b/drivers/net/wireless/rtl8723ds/hal/rtl8723d/sdio/rtl8723ds_recv.c
index 18880983904b..f6a9fe75546e 100644
--- a/drivers/net/wireless/rtl8723ds/hal/rtl8723d/sdio/rtl8723ds_recv.c
+++ b/drivers/net/wireless/rtl8723ds/hal/rtl8723d/sdio/rtl8723ds_recv.c
@@ -161,9 +161,9 @@ s32 rtl8723ds_recv_hdl(_adapter *padapter)
 	return _SUCCESS;
 }
 
-static void rtl8723ds_recv_tasklet(void *priv)
+static void rtl8723ds_recv_tasklet(unsigned long priv)
 {
-	_adapter *adapter = (_adapter *)priv;
+	_adapter *adapter = (_adapter *)(uintptr_t)priv;
 	s32 ret;
 
 	ret = rtl8723ds_recv_hdl(adapter);
@@ -177,7 +177,7 @@ static void rtl8723ds_recv_tasklet(void *priv)
 	}
 }
 #else
-static void rtl8723ds_recv_tasklet(void *priv)
+static void rtl8723ds_recv_tasklet(unsigned long priv)
 {
 	PADAPTER				padapter;
 	PHAL_DATA_TYPE			pHalData;
@@ -190,7 +190,7 @@ static void rtl8723ds_recv_tasklet(void *priv)
 	_pkt		*ppkt;
 	u32		pkt_offset;
 
-	padapter = (PADAPTER)priv;
+	padapter = (PADAPTER)(uintptr_t)priv;
 	pHalData = GET_HAL_DATA(padapter);
 	precvpriv = &padapter->recvpriv;
 
@@ -403,7 +403,7 @@ s32 rtl8723ds_init_recv_priv(PADAPTER padapter)
 	/* 3 2. init tasklet */
 #ifdef PLATFORM_LINUX
 	tasklet_init(&precvpriv->recv_tasklet,
-		     (void(*)(unsigned long))rtl8723ds_recv_tasklet,
+		     rtl8723ds_recv_tasklet,
 		     (unsigned long)padapter);
 #endif