From: Tim-Philipp Müller <tim.muller@collabora.co.uk>
Date: Thu, 29 Apr 2010 22:26:54 +0000 (+0100)
Subject: element: make 'adding flushing pad' warning more useful
X-Git-Tag: RELEASE-0.10.30~196
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=ae56d7136310ab967479e1e0b6280cd06c46094d;p=platform%2Fupstream%2Fgstreamer.git

element: make 'adding flushing pad' warning more useful

This is a pretty common issue with ghost pads, let's make
the warning more helpful and tell people what they need
to do to fix it.
---

diff --git a/gst/gstelement.c b/gst/gstelement.c
index a340d6c..99c5d19 100644
--- a/gst/gstelement.c
+++ b/gst/gstelement.c
@@ -712,7 +712,8 @@ gst_element_add_pad (GstElement * element, GstPad * pad)
   /* check for flushing pads */
   if (flushing && (GST_STATE (element) > GST_STATE_READY ||
           GST_STATE_NEXT (element) == GST_STATE_PAUSED)) {
-    g_warning ("adding flushing pad '%s' to running element '%s'",
+    g_warning ("adding flushing pad '%s' to running element '%s', you need to "
+        "use gst_pad_set_active(pad,TRUE) before adding it.",
         GST_STR_NULL (pad_name), GST_ELEMENT_NAME (element));
     /* unset flushing */
     GST_OBJECT_LOCK (pad);