From: Uros Bizjak Date: Thu, 27 Jan 2022 21:14:18 +0000 (+0100) Subject: testsuite: Fix gfortran.dg/ieee/signaling_?.f90 tests for x86 targets X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=ae1b50e2e03aad06408b64c876f5d0511121de0d;p=test_jj.git testsuite: Fix gfortran.dg/ieee/signaling_?.f90 tests for x86 targets As stated in signaling_?.f90 tests, x86-32 ABI is not suitable to correctly handle signaling NaNs. However, XFAIL is not the correct choice to disable these tests, since various optimizations can generate code that avoids moves from registers to memory (and back), resulting in the code that executes correctly, producing spurious XFAIL. These tests should be disabled on x86-32 using { ! ia32 } dg-directive which rules out x32 ilp32 ABI, where tests execute without problems. Please note that check_effective_target_ia32 test tries to compile code that uses __i386__ target-dependent preprocessor definition, so it is guaranteed to fail on all non-ia32 targets. 2022-01-27 Uroš Bizjak gcc/testsuite/ChangeLog: * gfortran.dg/ieee/signaling_1.f90 (dg-do): Run only on non-ia32 targets. * gfortran.dg/ieee/signaling_2.f90 (dg-do): Ditto. * gfortran.dg/ieee/signaling_3.f90 (dg-do): Ditto. --- diff --git a/gcc/testsuite/gfortran.dg/ieee/signaling_1.f90 b/gcc/testsuite/gfortran.dg/ieee/signaling_1.f90 index 2b15681..19fee28 100644 --- a/gcc/testsuite/gfortran.dg/ieee/signaling_1.f90 +++ b/gcc/testsuite/gfortran.dg/ieee/signaling_1.f90 @@ -1,4 +1,4 @@ -! { dg-do run { xfail { { i?86-*-* x86_64-*-* } && ilp32 } } } +! { dg-do run { target { ! ia32 } } } ! x87 / x86-32 ABI is unsuitable for signaling NaNs ! ! { dg-additional-sources signaling_1_c.c } diff --git a/gcc/testsuite/gfortran.dg/ieee/signaling_2.f90 b/gcc/testsuite/gfortran.dg/ieee/signaling_2.f90 index ee38052..03b04c7 100644 --- a/gcc/testsuite/gfortran.dg/ieee/signaling_2.f90 +++ b/gcc/testsuite/gfortran.dg/ieee/signaling_2.f90 @@ -1,4 +1,4 @@ -! { dg-do run { xfail { { i?86-*-* x86_64-*-* } && ilp32 } } } +! { dg-do run { target { ! ia32 } } } ! x87 / x86-32 ABI is unsuitable for signaling NaNs ! ! { dg-require-effective-target issignaling } */ diff --git a/gcc/testsuite/gfortran.dg/ieee/signaling_3.f90 b/gcc/testsuite/gfortran.dg/ieee/signaling_3.f90 index 22b3698..ff2585d 100644 --- a/gcc/testsuite/gfortran.dg/ieee/signaling_3.f90 +++ b/gcc/testsuite/gfortran.dg/ieee/signaling_3.f90 @@ -1,4 +1,4 @@ -! { dg-do run { xfail { { i?86-*-* x86_64-*-* } && ilp32 } } } +! { dg-do run { target { ! ia32 } } } ! x87 / x86-32 ABI is unsuitable for signaling NaNs ! program test