From: Hema Prathaban <hemaklnce@gmail.com>
Date: Tue, 14 May 2013 15:29:19 +0000 (+0530)
Subject: staging: rtl8192e: Fix potential null dereference
X-Git-Tag: upstream/snapshot3+hdmi~4847^2~746
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=ae053253a7971b6c97ad570e0f373974ca6d7e06;p=platform%2Fadaptation%2Frenesas_rcar%2Frenesas_kernel.git

staging: rtl8192e: Fix potential null dereference

check memory is allocated in '*challenge' before using it.

Signed-off-by: Hema Prathaban <hemaklnce@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/drivers/staging/rtl8192e/rtllib_softmac.c b/drivers/staging/rtl8192e/rtllib_softmac.c
index 4feecec..8af0b99 100644
--- a/drivers/staging/rtl8192e/rtllib_softmac.c
+++ b/drivers/staging/rtl8192e/rtllib_softmac.c
@@ -1802,7 +1802,9 @@ static inline u16 auth_parse(struct sk_buff *skb, u8** challenge, int *chlen)
 		if (*(t++) == MFIE_TYPE_CHALLENGE) {
 			*chlen = *(t++);
 			*challenge = kmalloc(*chlen, GFP_ATOMIC);
-			memcpy(*challenge, t, *chlen);	/*TODO - check here*/
+			if (!*challenge)
+				return -ENOMEM;
+			memcpy(*challenge, t, *chlen);
 		}
 	}
 	return cpu_to_le16(a->status);