From: dslomov@chromium.org Date: Wed, 11 May 2011 17:29:47 +0000 (+0000) Subject: Speculative fix fo MultithreadedParallelIsolates on ARM X-Git-Tag: upstream/4.7.83~19431 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=adfa56af549f4a9b4f92098ce93b3b89631e87e9;p=platform%2Fupstream%2Fv8.git Speculative fix fo MultithreadedParallelIsolates on ARM It looks like the problem with the test is too many concurrently created isolates. Cranking the number to 100 on MacOS and Linux produce similar results. BUG=http://code.google.com/p/v8/issues/detail?id=1375 TBR=vitalyr git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@7869 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 --- diff --git a/test/cctest/cctest.status b/test/cctest/cctest.status index 9e2872f3d..47ea30211 100644 --- a/test/cctest/cctest.status +++ b/test/cctest/cctest.status @@ -52,9 +52,6 @@ test-func-name-inference/PassedAsConstructorParameter: FAIL ############################################################################## [ $arch == arm ] -# BUG(1375): Test crashes on ARM. -test-lockers/MultithreadedParallelIsolates: SKIP - # We cannot assume that we can throw OutOfMemory exceptions in all situations. # Apparently our ARM box is in such a state. Skip the test as it also runs for # a long time. diff --git a/test/cctest/test-lockers.cc b/test/cctest/test-lockers.cc index ba0fdb220..5b33f2ee0 100644 --- a/test/cctest/test-lockers.cc +++ b/test/cctest/test-lockers.cc @@ -240,7 +240,11 @@ class IsolateNonlockingThread : public JoinableThread { // Run many threads each accessing its own isolate without locking TEST(MultithreadedParallelIsolates) { +#ifdef V8_TARGET_ARCH_ARM + const int kNThreads = 10; +#else const int kNThreads = 50; +#endif i::List threads(kNThreads); for (int i = 0; i < kNThreads; i++) { threads.Add(new IsolateNonlockingThread());