From: Sebastian Dröge <sebastian@centricular.com>
Date: Thu, 27 Jan 2022 12:22:26 +0000 (+0200)
Subject: rtphdrext: Return non-floating references from `gst_rtp_header_extension_create_from_... 
X-Git-Tag: 1.20.0~47
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=adf80ad1a7a2fbd190e8590e24074da2ad352e4e;p=platform%2Fupstream%2Fgstreamer.git

rtphdrext: Return non-floating references from `gst_rtp_header_extension_create_from_uri()`

The header extension objects are never getting a parent object and using
floating references only complicates usage, especially via dynamic API
like signals.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1582>
---

diff --git a/subprojects/gst-plugins-base/gst-libs/gst/rtp/gstrtphdrext.c b/subprojects/gst-plugins-base/gst-libs/gst/rtp/gstrtphdrext.c
index 1116525..48fdd83 100644
--- a/subprojects/gst-plugins-base/gst-libs/gst/rtp/gstrtphdrext.c
+++ b/subprojects/gst-plugins-base/gst-libs/gst/rtp/gstrtphdrext.c
@@ -858,6 +858,8 @@ gst_rtp_header_extension_create_from_uri (const gchar * uri)
 
     g_list_free_full (l, (GDestroyNotify) gst_object_unref);
 
+    gst_object_ref_sink (element);
+
     return GST_RTP_HEADER_EXTENSION (element);
   }