From: Michael Buch Date: Thu, 12 Jan 2023 12:06:03 +0000 (+0000) Subject: [lldb] Fix typo in integral format specifier X-Git-Tag: upstream/17.0.6~21219 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=ade3f1ccd807b00122fdf374ce85987fee60f853;p=platform%2Fupstream%2Fllvm.git [lldb] Fix typo in integral format specifier This regressed with `e262b8f48af9fdca8380f2f079e50291956aad71`. Two issues here: 1. `:16x` is not a valid format specifier and we would crash when we encountered this log (which was the case in `TestCPPAccelerator.py`) 2. The third argument was missing curly braces so the log message itself was malformed. --- diff --git a/lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp b/lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp index 162013f..9f042e9 100644 --- a/lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp +++ b/lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp @@ -430,7 +430,7 @@ TypeSP DWARFASTParserClang::ParseTypeFromDWARF(const SymbolContext &sc, log, "DWARFASTParserClang::ParseTypeFromDWARF " "(die = {0:x16}, decl_ctx = {1:p} (die " - "{2:16x})) (3:s) name = '{4}')", + "{2:x16})) {3} name = '{4}')", die.GetOffset(), static_cast(context), context_die.GetOffset(), die.GetTagAsCString(), die.GetName()); }