From: joonbum.ko <joonbum.ko@samsung.com>
Date: Mon, 29 Jan 2018 10:51:54 +0000 (+0900)
Subject: null-driver: Fixed to prevent memory & nonterminated string problem.
X-Git-Tag: accepted/tizen/unified/20180208.163712~2
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=add07fd679329c012f2a1bd5174d2519e2916b1a;p=platform%2Fcore%2Fuifw%2Fvulkan-wsi-tizen.git

null-driver: Fixed to prevent memory & nonterminated string problem.

 - MEMORY_LEAK.EX WGID: 305114
 - NONTERMINATING_STRING.STYLE WGID: 305119

Change-Id: I4a0c991db6e18974f72f0e1d0ce26e1e91c97706
Signed-off-by: joonbum.ko <joonbum.ko@samsung.com>
---

diff --git a/src/null-driver/null-driver.c b/src/null-driver/null-driver.c
index 8872f93..ce99542 100644
--- a/src/null-driver/null-driver.c
+++ b/src/null-driver/null-driver.c
@@ -523,8 +523,10 @@ nulldrv_mem_alloc(struct nulldrv_dev *dev,
 		return VK_ERROR_OUT_OF_HOST_MEMORY;
 
 	mem->bo = malloc(info->allocationSize);
-	if (!mem->bo)
+	if (!mem->bo) {
+		free(mem);
 		return VK_ERROR_OUT_OF_HOST_MEMORY;
+	}
 
 	mem->size = info->allocationSize;
 
@@ -1451,6 +1453,8 @@ get_physical_device_properties(VkPhysicalDevice pdev,
 	props->deviceID = 0;
 	props->deviceType = VK_PHYSICAL_DEVICE_TYPE_OTHER;
 	strncpy(props->deviceName, "nulldrv", strlen("nulldrv"));
+	if (strlen("nulldrv") < VK_MAX_PHYSICAL_DEVICE_NAME_SIZE)
+		props->deviceName[strlen("nulldrv")] = '\0';
 
 	/* TODO: fill out limits */
 	memset(&props->limits, 0, sizeof(VkPhysicalDeviceLimits));