From: ager@chromium.org <ager@chromium.org@ce2b1a6d-e550-0410-aec6-3dcde31c8c00>
Date: Tue, 20 Jul 2010 05:51:10 +0000 (+0000)
Subject: Land for Victor Wang.
X-Git-Tag: upstream/4.7.83~21469
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=adc2ff755db0a78903a9736b9f6eeb918e045a44;p=platform%2Fupstream%2Fv8.git

Land for Victor Wang.

Add direct_dependent_settings for v8 dll so targets that depend on v8
has USING_V8_SHARED defined.

Review URL: http://codereview.chromium.org/2946014/show

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5099 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
---

diff --git a/tools/gyp/v8.gyp b/tools/gyp/v8.gyp
index 8c7ae37..839ae0b 100644
--- a/tools/gyp/v8.gyp
+++ b/tools/gyp/v8.gyp
@@ -181,6 +181,11 @@
           'defines': [
             'BUILDING_V8_SHARED'
           ],
+          'direct_dependent_settings': {
+            'defines': [
+              'USING_V8_SHARED',
+            ],
+          },
         },
         {
           'type': 'none',
@@ -738,11 +743,6 @@
           # This could be gotten by not setting chromium_code, if that's OK.
           'defines': ['_CRT_SECURE_NO_WARNINGS'],
         }],
-        ['OS=="win" and component=="shared_library"', {
-          'defines': [
-            'USING_V8_SHARED',
-          ],
-        }],
       ],
     },
   ],